fix(@formatjs/fast-memoize)!: use named exports#4030
Merged
pyrocat101 merged 1 commit intomainfrom Mar 19, 2023
Merged
Conversation
3123b08 to
352d98f
Compare
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| "exports": { | ||
| "import": "./lib/index.js", |
There was a problem hiding this comment.
This breaks native ESM support. When using a native import, it resolves to this export condition. This export condition resolves to a .js file. Because this package.json doesn’t specify "type": "module", this file is treated as CJS. However, it contains ESM syntax, which is a syntax error.
To fix this, this file should have a .mjs file extension. The accompanying type definitions should use a .d.mts file extension.
unional
pushed a commit
to unional/formatjs
that referenced
this pull request
Jun 7, 2023
Fixes formatjs#3999 BREAKING CHANGE: `memoize` is now a named exports rather than a default exporst to workaround shenaginans of bundler compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3999
BREAKING CHANGE:
memoizeis now a named exports rather than a default exporst to workaround shenaginans of bundler compatibility.