Skip to content

chore(deps): update dependency aspect_rules_js to v3#6135

Merged
longlho merged 2 commits intomainfrom
renovate/aspect_rules_js-3.x
Mar 17, 2026
Merged

chore(deps): update dependency aspect_rules_js to v3#6135
longlho merged 2 commits intomainfrom
renovate/aspect_rules_js-3.x

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Mar 17, 2026

This PR contains the following updates:

Package Type Update Change
aspect_rules_js bazel_dep major 2.9.23.0.3

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@longlho
Copy link
Member

longlho commented Mar 17, 2026

CI failure is an upstream bug in aspect_rules_js@3.0.3 — its MODULE.bazel:34 passes None as repo_name to bazel_dep():

Error in bazel_dep: in call to bazel_dep(), parameter 'repo_name' got value of type 'NoneType', want 'string'
Error computing the main repository mapping: in module dependency chain <root> -> aspect_rules_js@3.0.3

Blocked until upstream releases a fix.

longlho added a commit that referenced this pull request Mar 17, 2026
## Problem
CI is running Bazel **8.1.0** despite `.bazelversion` specifying
**9.0.1**. The `setup-bazel` bazelisk cache was poisoned — it cached the
Bazel 8.1.0 binary under the hash for `.bazelversion` content `9.0.1`,
and every subsequent run restores the wrong binary.

This causes `aspect_rules_js` v3 upgrade (#6135) to fail because Bazel
8.1.0 doesn't support `repo_name = None` in `bazel_dep()`.

## Fix
Disable `bazelisk-cache` in all 6 workflows. Bazelisk download is ~2-3
seconds, so the cache savings are negligible compared to the risk of
version mismatch.

## Affected workflows
- `.github/workflows/test.yml` (2 jobs)
- `.github/workflows/verify-hooks.yml`
- `.github/workflows/release.yml`
- `.github/workflows/rust-cli-release.yml`
- `.github/workflows/website.yml`
- `.github/workflows/typesense-index.yml`

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@longlho
Copy link
Member

longlho commented Mar 17, 2026

@renovate rebase

@renovate renovate bot force-pushed the renovate/aspect_rules_js-3.x branch from a3ad32c to 8d28531 Compare March 17, 2026 18:21
longlho added a commit that referenced this pull request Mar 17, 2026
## Problem
`.bazeliskrc` has `USE_BAZEL_VERSION=8.1.0` which **overrides**
`.bazelversion` (priority: `.bazeliskrc` > `.bazelversion`). This means
all CI and local builds have been running Bazel 8.1.0 despite
`.bazelversion` being bumped to 9.0.1 in #6077.

This is the root cause of #6135 failing — `aspect_rules_js@3.0.3` uses
`repo_name = None` which requires Bazel >=7.6 but works differently on
8.x vs 9.x.

## Fix
Update `USE_BAZEL_VERSION` in `.bazeliskrc` to `9.0.1` to match
`.bazelversion`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@longlho longlho enabled auto-merge (squash) March 17, 2026 21:38
@renovate renovate bot force-pushed the renovate/aspect_rules_js-3.x branch from 8d28531 to ca4a330 Compare March 17, 2026 21:40
In rules_js v3, ts_project and js_run_binary auto-copy srcs to bin,
causing conflicting actions when multiple targets use the same source
files. Fix by creating a single shared copy_to_bin target for all
source/public files that all targets reference.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@longlho longlho merged commit 561195f into main Mar 17, 2026
5 checks passed
@longlho longlho deleted the renovate/aspect_rules_js-3.x branch March 17, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant