[SMALL] UX: Rename "Start an ask me anything" to "Start an AMA"#2428
Merged
maestromac merged 1 commit intoforem:masterfrom Apr 19, 2019
venarius:cta_button_width
Merged
[SMALL] UX: Rename "Start an ask me anything" to "Start an AMA"#2428maestromac merged 1 commit intoforem:masterfrom venarius:cta_button_width
maestromac merged 1 commit intoforem:masterfrom
venarius:cta_button_width
Conversation
Contributor
|
Which browser are you using? With Chrome 73 I don't notice this issue. It might have something to do with the front. |
Contributor
|
I have Chrome 74 on Ubuntu and have the issue with all the font options available in settings.
|
Author
|
yup, same. It have the same issue on ubuntu and chrome |
Contributor
|
Having thought about this, I don't think the button should be meaningfully bigger. How about we change the text here to "START AN AMA" instead? The font problem is that helvetica-condensed is not compatible across all browsers. We should explore other ideas related to how we deal with fonts across the site. I'm still pretty happy that we don't load in heavy external fonts. |
Author
|
@benhalpern sounds like a good idea, but I don't think a greater button width would have done harm here. Just force-pushed with the change you suggested. |
coreyja
added a commit
to coreyja/dev.to
that referenced
this pull request
Apr 20, 2019
* master: (83 commits) Update gitdocs (forem#2500) Condense 'ask me anything' to 'ama' (forem#2428) [ci skip] Add user_signed_in? to cache key for styles (forem#2498) Added troubleshooting for byebug without readline issue (forem#2481) Fix some frontend linting issues (forem#2495) [ci skip] Fix <br/> in footer. (forem#2491) Remove extra param and add message for prefill (forem#2487) Make Cards Change Dynamically and add Reader/Follower Charts (forem#2488) Temporarily comment out random (forem#2486) Add nav buttons to pwa desktop (forem#2484) Feature/filtered charts (forem#2482) Add caching for historical data (forem#2476) There are installation sections for other OSes now. (forem#2480) Add inbox guidelines to users (forem#2473) Release Open Inbox (forem#2468) Convert underscores in article slugs properly (forem#2472) Update framework defaults to match those in Rails 5.1 (forem#2309) Enable random order for specs (forem#2466) [ci skip] forem#118 Allow users to embed Medium posts with Liquid Tags (forem#1161) Allow API to return top articles (forem#2469) ... # Conflicts: # Envfile # app/models/user.rb # db/schema.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I randomly noticed the "Start an ask me anything" button and found that it looked very squished. I increased its width.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before
After
Added to documentation?