Skip to content

Quick API fix#11

Merged
foo-git merged 1 commit intofoo-git:masterfrom
Timon-Schneider:api_fix
Mar 26, 2023
Merged

Quick API fix#11
foo-git merged 1 commit intofoo-git:masterfrom
Timon-Schneider:api_fix

Conversation

@Timon-Schneider
Copy link
Copy Markdown
Contributor

replaced the API URL that was responsible for listing the markets.
also adjusted the associated filters.
closes #10

replaced the API URL that was responsible for listing the markets.
also adjusted the associated filters.
@foo-git foo-git merged commit 42faa55 into foo-git:master Mar 26, 2023
@foo-git
Copy link
Copy Markdown
Owner

foo-git commented Mar 26, 2023

I tested it with some postal codes, it works as intended.
Thanks for your quick contribution!

foo-git added a commit that referenced this pull request May 18, 2023
* Add support for 7 digit market ids

Market seem to have 7 digit market ids as shown in `python3 ./rewe_discounts/rewe_discounts.py --list-markets 10405`

* Updated API url and data processing as API output changed.

* Quick API fix (#11)

replaced the API URL that was responsible for listing the markets.
also adjusted the associated filters.

* Improved error handling and debugging messages.

---------

Co-authored-by: Oliver Wehrens <oliver@wehrens.de>
Co-authored-by: Timon Schneider <78318928+Timon-Schneider@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error fetching API while retrieving market id

2 participants