Skip to content

[feaLib] Allow deleting glyphs#2170

Merged
simoncozens merged 2 commits intofonttools:masterfrom
simoncozens:delete-glyph
Feb 3, 2021
Merged

[feaLib] Allow deleting glyphs#2170
simoncozens merged 2 commits intofonttools:masterfrom
simoncozens:delete-glyph

Conversation

@simoncozens
Copy link
Copy Markdown
Collaborator

Support "sub A by NULL;" as described in adobe-type-tools/afdko#1234 and implemented in AFDKO as adobe-type-tools/afdko#1251

Copy link
Copy Markdown
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Simon!

@anthrotype
Copy link
Copy Markdown
Member

(btw, that parse_substitute_ method is 166 lines long.. one day maybe we should split it up into more manageable chunks)

@simoncozens simoncozens merged commit 45201f6 into fonttools:master Feb 3, 2021
@ctrlcctrlv
Copy link
Copy Markdown
Contributor

👀

dude…you can delete glyphs in OT Layout?

cool…wow. This makes a lot of hacks I've considered but then gave up on possible.

@justvanrossum
Copy link
Copy Markdown
Collaborator

See also MicrosoftDocs/typography-issues#673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants