[ufo] Don't unnecessarily write UFO's metainfo.plist when we're only reading#2505
Merged
justvanrossum merged 8 commits intomainfrom Mar 21, 2026
Merged
[ufo] Don't unnecessarily write UFO's metainfo.plist when we're only reading#2505justvanrossum merged 8 commits intomainfrom
justvanrossum merged 8 commits intomainfrom
Conversation
…s, because we can't distinguish them at runtime
… wrt. the writing of ufo's metainfo.plist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2504.
Instead of using the multipurpose UFOReaderWriter (alias for UFOWriter), use UFOReader as long a we are not writing. This required reworking how readers/writers are cached, as well as UFO GlyphSet objects. Typechecking helped to ensure this is done correctly.