[designspace] write italic angle source property to UFO#2389
[designspace] write italic angle source property to UFO#2389justvanrossum merged 2 commits intomainfrom
Conversation
| setattr(fontInfo, ufoName, round(metric.value)) | ||
|
|
||
| fontInfo.italicAngle = fontSource.italicAngle | ||
|
|
There was a problem hiding this comment.
This would mean that the last source read defines italicAngle in the post table for the whole font, correct? That is, that setting is unused/discarded upon export for any other source but the last one.
I see how each source in a font design can have its own italic angle (certainly when defining a slant axis), but is that data used anywhere else now?
There was a problem hiding this comment.
No, this is a per-source setting, and generally each Fontra font source corresponds to a UFO in the designspace system. So it is individual per UFO. However...
On export as .ttf or .otf only a single value will go into the font as this field is not variable. I'm guessing that font compilers will take the value from the default source in a system.
There was a problem hiding this comment.
(I partly misread your comment, you were talking about the post table already. I suppose only the last bit of my answer is relevant to your question.)
This fixes #2386.