Skip to content

Fix CI for Ubuntu 24#5531

Merged
skef merged 6 commits intofontforge:masterfrom
iorsh:ci_ubuntu_24
Mar 27, 2025
Merged

Fix CI for Ubuntu 24#5531
skef merged 6 commits intofontforge:masterfrom
iorsh:ci_ubuntu_24

Conversation

@iorsh
Copy link
Copy Markdown
Contributor

@iorsh iorsh commented Jan 22, 2025

ubuntu-latest CI runner now defaults to Ubuntu 24.04 (see actions/runner-images#10636). This PR fixes the issues which arose with the new version.

@iorsh
Copy link
Copy Markdown
Contributor Author

iorsh commented Jan 22, 2025

Mac is failing with hdiutil: create failed - Resource busy error, which I've been observing coming and going for a few months now. Probably some instability, please ignore.

@iorsh
Copy link
Copy Markdown
Contributor Author

iorsh commented Jan 22, 2025

Windows CI is pending jtanx/fontforgebuilds#23

jtanx
jtanx reviewed Feb 4, 2025
View reviewed changes
Comment thread .github/workflows/main.yml
working-directory: repo
run: |
# There can be several Python versions installed. We must use the exact one discovered by CMake.
PYTHON=`grep -m1 'Python3_EXECUTABLE.*=' build/CMakeCache.txt | cut -d= -f2`
Copy link
Copy Markdown
Contributor

@jtanx jtanx Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the original version it selects is influenced by the PYTHON environment variable set above?

Copy link
Copy Markdown
Contributor Author

@iorsh iorsh Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which one do you mean? I removed PYTHON: python3.10 at line 13 above.

PYTHON=python3 in setup_linux_deps.sh only serves the installation. Whatever is installed there would be later discovered by CMake and used accordingly.

@iorsh
Copy link
Copy Markdown
Contributor Author

iorsh commented Mar 18, 2025

@skef, @jtanx, could you please review? This PR should finalise the CI issues for the time being.

skef
skef approved these changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with all of this. I'll pause merging for a few days to see if @jtanx has further comments.

@iorsh
Copy link
Copy Markdown
Contributor Author

iorsh commented Mar 24, 2025

In an unrelated issue, the standalone typing package uses deprecated setuptools environment, and is now broken. We don't need it, since typing module is a part of standard Python since 3.5.

For more information: pypa/setuptools#4870.
I also erroneously blamed sphynx for this, but its maintainers kindly pointed me in the right direction.

@skef skef merged commit 072208f into fontforge:master Mar 27, 2025
7 checks passed
@iorsh iorsh deleted the ci_ubuntu_24 branch March 28, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtanx jtanx jtanx left review comments

@skef skef skef approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iorsh @jtanx @skef