Merged
Conversation
This was referenced Jan 18, 2025
Contributor
Author
|
@jtanx, could you please review? |
jtanx
reviewed
Feb 4, 2025
| WORK=$BASE/work/$MINGVER/ | ||
| PMTEST="$BASE/.pacman-$MINGVER-installed" | ||
| PYINST=python3 | ||
| PYINST=python |
Owner
There was a problem hiding this comment.
https://github.com/fontforge/fontforge/actions/runs/12917757007/job/36024837540?pr=5531
That build complains about mingw-w64-x86_64-python-pip? Is this really needed after applying Syy?
Contributor
Author
There was a problem hiding this comment.
Yes, I tried with "python3", and it didn't work. Note the errors in Run FontForgeBulds initialisation:
error: target not found: mingw-w64-x86_64-python3-pip
error: target not found: mingw-w64-x86_64-python3-setuptools
Contributor
Author
|
@jtanx, do you have any comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hack intended to overcome issues with Python3 installation via
pacman. There is probably some instability in GitHub MSYS2 environment, as I can't see a reasonable explanation for these changes.python3is an alias forpython, and package e.g.mingw-w64-i686-python3-pipshould point tomingw-w64-i686-python-pip. For some reason it doesn't.-yy, but it shouldn't be necessary in a freshly installed MSYS2 environment.