Only install GUI-specific files if ENABLE_GUI is set#5451
Merged
skef merged 1 commit intofontforge:masterfrom Oct 12, 2024
Merged
Only install GUI-specific files if ENABLE_GUI is set#5451skef merged 1 commit intofontforge:masterfrom
skef merged 1 commit intofontforge:masterfrom
Conversation
Contributor
|
This is reasonable but it scares me. I'll approve if someone (e.g. @iorsh) looks into it and thinks it's OK. |
Contributor
|
Looks good to me. We also have NoUI CI pipeline, so if it doesn't break, we would be good to go. |
iorsh
approved these changes
Oct 7, 2024
skef
approved these changes
Oct 7, 2024
The desktop menu entry and MIME association are not usable if the GUI is not installed. There are also hundreds of unused image files.
Contributor
Author
|
The checks seemed stuck - so I rebased (as the changes are tiny hopefully that in itself isn't too much of a pain) - but now seems like they need approval. |
iorsh
pushed a commit
to iorsh/fontforge
that referenced
this pull request
Oct 16, 2024
The desktop menu entry and MIME association are not usable if the GUI is not installed. There are also hundreds of unused image files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop menu entry and MIME association are not usable if the GUI is not installed.
There are also hundreds of unused image files.
This reduces the number of files installed for me from 412 to 40.
Type of change