Skip to content

Fix Splinefont shell invocation#5367

Merged
skef merged 1 commit intofontforge:masterfrom
pkvanca:pkvanca-ff-splinefont-patch
Feb 6, 2024
Merged

Fix Splinefont shell invocation#5367
skef merged 1 commit intofontforge:masterfrom
pkvanca:pkvanca-ff-splinefont-patch

Conversation

@pkvanca
Copy link
Copy Markdown
Contributor

@pkvanca pkvanca commented Feb 6, 2024

This patch addresses security vulnerabilities arising from how FontForge opens certain files. The code has been changed to use glib's g_spawn_sync/async functions that do not execute commands through a shell. This patch should still retain all of the original functionality and introduce no breaking changes, having passed all tests as well.

As discussed with the maintainers via email, opening a public PR here.

Addresses CVES:

Type of change

  • Bug fix

Copy link
Copy Markdown
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skef skef merged commit 216eb14 into fontforge:master Feb 6, 2024
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request May 6, 2025
Pick commit from PR [1] linked from [2] and [3] which mlso entions both
these CVEs.

[1] fontforge/fontforge#5367
[2] https://nvd.nist.gov/vuln/detail/CVE-2024-25081
[3] https://nvd.nist.gov/vuln/detail/CVE-2024-25082

Signed-off-by: Peter Marko <peter.marko@siemens.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
OldManYellsAtCloud pushed a commit to OldManYellsAtCloud/meta-openembedded that referenced this pull request Sep 6, 2025
Pick commit from PR [1] linked from [2] and [3] which mlso entions both
these CVEs.

[1] fontforge/fontforge#5367
[2] https://nvd.nist.gov/vuln/detail/CVE-2024-25081
[3] https://nvd.nist.gov/vuln/detail/CVE-2024-25082

Signed-off-by: Peter Marko <peter.marko@siemens.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
OldManYellsAtCloud pushed a commit to OldManYellsAtCloud/meta-openembedded that referenced this pull request Sep 6, 2025
Pick commit from PR [1] linked from [2] and [3] which mlso entions both
these CVEs.

[1] fontforge/fontforge#5367
[2] https://nvd.nist.gov/vuln/detail/CVE-2024-25081
[3] https://nvd.nist.gov/vuln/detail/CVE-2024-25082

Signed-off-by: Peter Marko <peter.marko@siemens.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
OldManYellsAtCloud pushed a commit to OldManYellsAtCloud/meta-openembedded that referenced this pull request Sep 6, 2025
Pick commit from PR [1] linked from [2] and [3] which mlso entions both
these CVEs.

[1] fontforge/fontforge#5367
[2] https://nvd.nist.gov/vuln/detail/CVE-2024-25081
[3] https://nvd.nist.gov/vuln/detail/CVE-2024-25082

Signed-off-by: Peter Marko <peter.marko@siemens.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
OldManYellsAtCloud pushed a commit to OldManYellsAtCloud/meta-openembedded that referenced this pull request Sep 7, 2025
Pick commit from PR [1] linked from [2] and [3] which mlso entions both
these CVEs.

[1] fontforge/fontforge#5367
[2] https://nvd.nist.gov/vuln/detail/CVE-2024-25081
[3] https://nvd.nist.gov/vuln/detail/CVE-2024-25082

Signed-off-by: Peter Marko <peter.marko@siemens.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
jpuhlman pushed a commit to MontaVista-OpenSourceTechnology/meta-openembedded that referenced this pull request Nov 4, 2025
Source: meta-openembedded
MR: 296370
Type: Integration
Disposition: Merged from meta-openembedded
ChangeID: 06a0862
Description:

Pick commit from PR [1] linked from [2] and [3] which mlso entions both
these CVEs.

[1] fontforge/fontforge#5367
[2] https://nvd.nist.gov/vuln/detail/CVE-2024-25081
[3] https://nvd.nist.gov/vuln/detail/CVE-2024-25082

Signed-off-by: Peter Marko <peter.marko@siemens.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
(cherry picked from commit 1e6dbd1)
Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants