Handle non-array cm transforms while reading graphics stream from PDFs#4965
Merged
jtanx merged 1 commit intofontforge:masterfrom Mar 25, 2022
Merged
Handle non-array cm transforms while reading graphics stream from PDFs#4965jtanx merged 1 commit intofontforge:masterfrom
jtanx merged 1 commit intofontforge:masterfrom
Conversation
Omnikron13
pushed a commit
to Omnikron13/fontforge
that referenced
this pull request
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the PDF graphics stream reader expects
cmoperations to have been preceded by an array of 6 values, but the spec suggests that we should be expecting numbers instead.This fix allows for popping the number operands from the stack. I've left the array behaviour in place because there are bound to be non-compliant writers producing array versions.