Add resource file and Windows application manifest#4950
Merged
jtanx merged 1 commit intofontforge:masterfrom Mar 22, 2022
Merged
Add resource file and Windows application manifest#4950jtanx merged 1 commit intofontforge:masterfrom
jtanx merged 1 commit intofontforge:masterfrom
Conversation
This forces UTF-8 encoding by default on newer versions of Windows, which fixes issues with accessing files containing characters outside of the system's default locale/encoding.
Omnikron13
pushed a commit
to Omnikron13/fontforge
that referenced
this pull request
May 31, 2022
This forces UTF-8 encoding by default on newer versions of Windows, which fixes issues with accessing files containing characters outside of the system's default locale/encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long time ago, I raised a point that files cannot be opened if they contain characters outside the currently active codepage in #2290. Ever since, Windows builds have actually been running with a set of patches to make that work better.
Most of these changes were presented as part of #2299, but were never merged because the changes were quite invasive, and it was still a pain to deal with.
Since then, improvements have been made to Windows which means that you can basically force the application encoding to UTF-8, and all the standard functions will then just work normally, as you would expect, fixing the issue.
This is a much better solution than the one previously proposed, and means I can drop those custom patches going forward.
Closes #2290.
Type of change