Conversation
It's completely dead code, the charview palettes are managed entirely outside of these provided functions.
Use GDrawSetWindowTitles8/GDrawGetWindowTitle8 instead.
Makes undocked palettes windows transient to the main window so that they stay on top even when unfocused. This used to work on Windows until a point release change of GDK 3.
When a window has no child windows, it was returning the window's exposable area, instead of intersecting that with the current expose event's region.
iconv is already a hard dependency.
| if ( enc==0 ) enc = -1; | ||
| } else if ( enc>0x100 ) | ||
| enc = badencoding(info); | ||
| // Apart from these, cp932 is a strict superset of sjis |
There was a problem hiding this comment.
This section may be the most contentious part, using iconv for reading the cmap encoding. But at least for SJIS, I think this is actually better. There are some encoding differences for gb2312/big5/wansung/johab, but it's hard to say if it's for the better or worse.
From testing purely the conversion routines, our custom rolled conversion tables were spitting out garbage conversions for at least some slots, but I don't know if that had any effect in practice. Also I guess iconv support may not be equal everywhere. But I believe we're already using iconv for everything else as-is (particularly for re-encoding).
This was/is really hard to test, non-unicode encoded fonts are so rare today.
There was a problem hiding this comment.
Using iconv is better because at least font developers know what iconv's choices are and what to look out for. Using our own tables, based just on George's opinions, makes things more confusing. So I agree with this change.
|
This pull request introduces 6 alerts when merging df1f76b into 52e8432 - view on LGTM.com new alerts:
|
|
Looks like we're having Windows build problems. |
|
Yeah, I'm looking into it (msys2/MINGW-packages#8186 (comment)) |
skef
left a comment
There was a problem hiding this comment.
Oh, thought I had approved this. Doing that now.
|
Looks like the cmake release is at least another week away so for now I've just pinned back to cmake 3.19 (fontforge/fontforgebuilds@c0067e1). Will rerun the other builds now. |
GDraw and Charset cleanup
This includes multiple changes, probably best viewed commit by commit. Primary focus is:
There are a couple of gdraw related bug fixes too, related to keeping the palettes window visible when undocked.
Closes #4334
Type of change