cmake: set rpath to the configure time CMAKE_INSTALL_PREFIX#4232
Merged
jtanx merged 1 commit intofontforge:masterfrom Mar 21, 2020
Merged
cmake: set rpath to the configure time CMAKE_INSTALL_PREFIX#4232jtanx merged 1 commit intofontforge:masterfrom
jtanx merged 1 commit intofontforge:masterfrom
Conversation
It can't be deferred until install time, as otherwise CMake won't know how much to pad the RPATH by. Fixes fontforge#4229
skef
approved these changes
Mar 21, 2020
nh2
added a commit
to nh2/nixpkgs
that referenced
this pull request
Jul 29, 2020
This was introduced in NixOS#89583 and fixed upstream with a master-only patch in fontforge/fontforge#4232. Found via nh2/static-haskell-nix#98 (comment).
10 tasks
nh2
added a commit
to nh2/nixpkgs
that referenced
this pull request
Jul 29, 2020
This was introduced in NixOS#89583 and fixed upstream with a master-only patch in fontforge/fontforge#4232. Found via nh2/static-haskell-nix#98 (comment).
Omnikron13
pushed a commit
to Omnikron13/fontforge
that referenced
this pull request
May 31, 2022
cmake: set rpath to the configure time CMAKE_INSTALL_PREFIX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can't be deferred until install time, as otherwise CMake won't know how much to pad the RPATH by. (Previously CMAKE_INSTALL_RPATH was only expanded at install time)
Fixes #4229
Type of change