Skip to content

fix dropdown cmp in "get item" - use unencoded value#3234

Merged
lubber-de merged 2 commits intofomantic:developfrom
mvorisek:fix_dropdown_cmp_in_get_item
Apr 3, 2025
Merged

fix dropdown cmp in "get item" - use unencoded value#3234
lubber-de merged 2 commits intofomantic:developfrom
mvorisek:fix_dropdown_cmp_in_get_item

Conversation

@mvorisek
Copy link
Copy Markdown
Contributor

@mvorisek mvorisek commented Mar 27, 2025

extracted from #3219

@mvorisek mvorisek marked this pull request as ready for review March 27, 2025 23:31
@mvorisek
Copy link
Copy Markdown
Contributor Author

I am 95% sure this fix is right, please review carefully.

@lubber-de
Copy link
Copy Markdown
Member

lubber-de commented Mar 28, 2025

I am a bit confused about the intention of this (and other ) PR :
in #3219 (comment) you want to remove the whole "raw" setting, which i so far (once) tested and it seems to be the right way .

With the other PRs you are now making use of the raw parameter.... is the final intention to keep the raw logic , intially invented in #1770, or not?

@mvorisek
Copy link
Copy Markdown
Contributor Author

mvorisek commented Mar 28, 2025

Here we change it from non-raw to raw. #3219 is refactoring PR only.

is the final intention to keep the raw logic , intially invented in #1770, or not?

Yes, raw only, non-raw does not make sense anywhere.

@mvorisek
Copy link
Copy Markdown
Contributor Author

Does this makes sense?

I maybe splitted the PR a little too much, but all 3 cases were quite different with very different repro steps, so I was a little to scared to solve them in a single PR...

Copy link
Copy Markdown
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de merged commit 7b9d63a into fomantic:develop Apr 3, 2025
8 checks passed
@lubber-de lubber-de added the type/bug Any issue which is a bug or PR which fixes a bug label Apr 3, 2025
@lubber-de lubber-de added this to the 2.10.0 milestone Apr 3, 2025
@mvorisek mvorisek deleted the fix_dropdown_cmp_in_get_item branch April 3, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/bug Any issue which is a bug or PR which fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants