Skip to content

Fix dropdown "get values" to always return raw value#3219

Merged
lubber-de merged 7 commits intofomantic:developfrom
mvorisek:dropdown_values_always_not_escaped
Apr 4, 2025
Merged

Fix dropdown "get values" to always return raw value#3219
lubber-de merged 7 commits intofomantic:developfrom
mvorisek:dropdown_values_always_not_escaped

Conversation

@mvorisek
Copy link
Copy Markdown
Contributor

@mvorisek mvorisek commented Mar 16, 2025 •
edited
Loading

Unify API, unencoded values are returned/accepted by other APIs.

@mvorisek mvorisek force-pushed the dropdown_values_always_not_escaped branch from d6419d1 to d80f0ba Compare March 16, 2025 01:02
@mvorisek
Copy link
Copy Markdown
Contributor Author

mvorisek commented Mar 16, 2025

The d80f0ba commit will probably break something as analysed in #3205 (review).

However, I belive "get values" API should return always the raw result no matter the !module.has.selectInput() && module.is.multiple() condition.

Help with adjusting the code where the result is used welcomed. I have not enough knowledge what/when the values should be escaped nor I am aware of old bugs/fixes.

@mvorisek mvorisek force-pushed the dropdown_values_always_not_escaped branch 3 times, most recently from b1ef7aa to 638bf2e Compare March 16, 2025 15:49
@lubber-de
Copy link
Copy Markdown
Member

lubber-de commented Mar 26, 2025 •
edited
Loading

Your PR basically reverts #1770
However, as you refactored/improved/simplified the whole encoding in #3205 the original PR changes really dont seem to be necessary anymore.

I quickly tested your latest commit with the original testcase and it seems to be fine 👍🏼
https://jsfiddle.net/lubber/2x31e5o8/1/

@mvorisek mvorisek force-pushed the dropdown_values_always_not_escaped branch 3 times, most recently from 9efaab9 to 7e5fac0 Compare March 27, 2025 10:09
This was referenced Mar 27, 2025
Merged
Merged
Merged
@mvorisek mvorisek force-pushed the dropdown_values_always_not_escaped branch from 7e5fac0 to 54f3751 Compare April 3, 2025 21:43
@mvorisek mvorisek marked this pull request as ready for review April 3, 2025 21:44
@mvorisek mvorisek changed the title Fix "get values" to return always raw value Fix dropdown "get values" to always return raw value Apr 3, 2025
@mvorisek
Copy link
Copy Markdown
Contributor Author

mvorisek commented Apr 3, 2025

Fixes were landed in #3233, #3234, #3235. PR is rebased and unchanged. Please review. There is no function change except the external API result fixed.

lubber-de
lubber-de approved these changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de merged commit 3be2655 into fomantic:develop Apr 4, 2025
8 checks passed
@lubber-de lubber-de added the type/bug Any issue which is a bug or PR which fixes a bug label Apr 4, 2025
@lubber-de lubber-de added this to the 2.10.0 milestone Apr 4, 2025
@mvorisek mvorisek deleted the dropdown_values_always_not_escaped branch April 4, 2025 20:39
This was referenced Apr 4, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@ko2in ko2in Awaiting requested review from ko2in

@prudho prudho Awaiting requested review from prudho

@y0hami y0hami Awaiting requested review from y0hami

Assignees

No one assigned

Labels

type/bug Any issue which is a bug or PR which fixes a bug

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mvorisek @lubber-de