Skip to content

feat(menu): rename tabular to tabbed#3201

Merged
lubber-de merged 2 commits intofomantic:developfrom
lubber-de:tabular2tabbed
Mar 21, 2025
Merged

feat(menu): rename tabular to tabbed#3201
lubber-de merged 2 commits intofomantic:developfrom
lubber-de:tabular2tabbed

Conversation

@lubber-de
Copy link
Copy Markdown
Member

@lubber-de lubber-de commented Mar 8, 2025

Description

As discussed in #2407 this PR renames tabluar menu to tabbed menu.

  • rename all .ui.tabular.menu selectors to .ui.tabbed.menu
  • rename all @...tabular... LESS variables to @...tabbed...

A new variation variable is introduced: @variationMenuTabbedLegacyTabular (default false)
When set to true, it will generate the old .tabular classes in addition to the .tabbed classes for easier migration (but will double all selectors which increases css filesize)

This is a BREAKING CHANGE as

  • custom themes won't work when they override @...tabular.. variables as those do not exists anymore
  • existing projects won't render tab menus properly unless all tabular usages are replaced by tabbed class usages

@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions tag/breaking-change Any pull request which is waiting for a breaking change release labels Mar 8, 2025
@lubber-de lubber-de added this to the 2.10.0 milestone Mar 8, 2025
Copy link
Copy Markdown
Member

@ko2in ko2in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lubber-de lubber-de merged commit 6d1b302 into fomantic:develop Mar 21, 2025
8 checks passed
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Mar 21, 2025
@lubber-de
Copy link
Copy Markdown
Member Author

Docs added by fomantic/Fomantic-UI-Docs#543

@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Mar 21, 2025
@lubber-de lubber-de deleted the tabular2tabbed branch March 21, 2025 19:36
lubber-de added a commit to fomantic/Fomantic-UI-Docs that referenced this pull request Mar 22, 2025
Renamed everything from "tabular" to "tabbed" as of fomantic/Fomantic-UI#3201
and added a hint how to compil using the old naming for quicker migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo tag/breaking-change Any pull request which is waiting for a breaking change release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants