[Range] implement SUI slider changes and more#290
Merged
y0hami merged 8 commits intofomantic:developfrom Dec 20, 2018
Merged
Conversation
y0hami
reviewed
Dec 6, 2018
Member
y0hami
left a comment
There was a problem hiding this comment.
Could you remove the dist files?
1ef41b3 to
3f5a43e
Compare
|
Cool! 😄 |
Member
|
Would it be a simple change to make it so the user can specify if they want the lines on the labeled slider something like |
Member
|
Looks great! Will do some testing later today |
Contributor
Author
I'd prefer name this option |
Member
|
@prudho That name is fine with me 😃 |
Contributor
Author
|
Done ! |
y0hami
reviewed
Dec 10, 2018
Contributor
|
This is a well oiled fork you all have here, glad the slider will get to live on as a part of it! |
This was referenced Dec 21, 2018
Merged
YamiOdymel
added a commit
to teacat/tocas
that referenced
this pull request
Dec 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds lot of features to the Range module, which is renamed to Slider for more consistency. It's based on many SUI's PRs, and some fixes of mine as well.
Here's what's new:
Range is now know as Slider.
Labeled silders:
Smooth or stepped slide:
Undefined step:
Reversed display:
Multisize:
Keyboard controlled:
Basic and basic inverted modes: no demo because i'm not satisfied yet :)
Vertical !⚠️ Needs heavy testing ⚠️
Last but not least, a real range slider 🎉:
And all of that features can be mixed up !
Closes
#117
#149
#150
Semantic-Org/Semantic-UI#1336
Thanks
@tyleryasaka, @gdaunton, @flytreeleft