Refactor on equality check function#1280
Merged
blikblum merged 1 commit intofoliojs:masterfrom Jul 13, 2021
Merged
Conversation
Avoidable 'if' statement
Member
|
Manu thanks |
leonho2001
added a commit
to leonho2001/pdfkit
that referenced
this pull request
Apr 29, 2022
Avoidable 'if' statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is just a minor refactor, I was going through the code and saw an "optimization" of an avoidable 'if' statement.
The boolean expression in the condition is enough to check the equality of the objects.