Add WAAC and WAIP awards and migration#1022
Merged
Merged
Conversation
Add new AwardWAAC and AwardWAIP classes (headers and implementations) and include them in the project SOURCES/HEADERS. Add a large SQL migration (migration_039.sql) populating adif_enum_primary_subdivision entries and register it in resources. Bump core migration version to 39 and update the AwardsDialog UI to integrate the new awards.
Change the include from "AwardWAAC.h" to "awardwaac.h" to match the actual header filename. This prevents build failures on case-sensitive filesystems and keeps include naming consistent.
Owner
|
@aa5sh thank you. Just one note. In the migration script, you are adding additional Regions. I am not sure if we want that there right now. Another thing. Can you send me the source you are using for this? I am not completely sure, but I think your previous PR included this as well, and I could not find your data to verify it, and in ADIF it was structured differently. |
Author
|
Ok I just figured if I was adding Italian ones may as well add the rest in case they come up for other requests or could be used later. But I pulled them from this: https://adif.org.uk/317/ADIF_317_resources_2026_03_22.zip
… On Apr 30, 2026, at 6:01 AM, Ladislav ***@***.***> wrote:
foldynl
left a comment
(foldynl/QLog#1022)
<#1022 (comment)>
@aa5sh <https://github.com/aa5sh> thank you.
Just one note. In the migration script, you are adding additional Regions. I am not sure if we want that there right now. Another thing. Can you send me the source you are using for this? I am not completely sure, but I think your previous PR included this as well, and I could not find your data to verify it, and in ADIF it was structured differently.
—
Reply to this email directly, view it on GitHub <#1022 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUEEMXVVWQ6DDBXOC3P3F4L4YMW77AVCNFSM6AAAAACYLSXCQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGNJRHA4DENJYGE>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new AwardWAAC and AwardWAIP classes (headers and implementations) and include them in the project SOURCES/HEADERS. Add a SQL migration (migration_039.sql) populating adif_enum_primary_subdivision entries and register it in resources. Bump core migration version to 39 and update the AwardsDialog UI to integrate the new awards. #1013