Fix standard default installation target presence#3264
Merged
vitaut merged 1 commit intofmtlib:masterfrom Jan 11, 2023
Merged
Conversation
Contributor
|
Thanks for the PR. I think it's reasonable to be consistent with CMake defaults. |
14 tasks
xkszltl
added a commit
to cyfitech/cris-core
that referenced
this pull request
Jun 3, 2024
Matan-B
added a commit
to Matan-B/ceph
that referenced
this pull request
Aug 14, 2024
See: fmtlib/fmt#3264 Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan-B
added a commit
to ceph/ceph-ci
that referenced
this pull request
Aug 15, 2024
See: fmtlib/fmt#3264 Signed-off-by: Matan Breizman <mbreizma@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently, for usage, installation, and packaging of the
fmtlibrary as transient dependency from third party CMake project, the extraneousFMT_INSTALLoption needs to be set, this option is unexpected, needs to be discovered by users.The CMake installation target for the
fmtlibrary should be present by default to conform to CMake defaults. Standard installation support simplifies usage in projects. The presence of the target, by default, allows standard CMake transient usage, installation, and packaging of thefmtlibrary in other projects.The extraneous configuration option can now be removed from projects using the library. Transient usage, packaging, installation follows. It simplifies usage. Users need not discover this option anymore. The library works like others. It would not override pre-installed, or pinned
fmtlibrary versions by downstream projects from CMake's "first to record, wins" approach which is what allows hierarchical projects to have parent projects override content details of child projects. Now, regular usage just works:Reference: https://cmake.org/cmake/help/latest/module/FetchContent.html