Skip to content

Merge upstream#1

Closed
aminya wants to merge 12 commits intofmeum:1920-cc-static-libraryfrom
aminya:merge-upstream
Closed

Merge upstream#1
aminya wants to merge 12 commits intofmeum:1920-cc-static-libraryfrom
aminya:merge-upstream

Conversation

@aminya
Copy link
Copy Markdown

@aminya aminya commented Nov 6, 2023

Merges upstream to update bazelbuild#16954

@fmeum fmeum force-pushed the 1920-cc-static-library branch 3 times, most recently from 5313d07 to de1669e Compare March 8, 2024 20:49
@aminya aminya closed this Mar 8, 2024
fmeum pushed a commit that referenced this pull request Mar 16, 2026
Previously, child events could be published before their parent events during a race in the `BuildEventStreamer#post` method. This method was not synchronized around delivering events to the `BuildEventTransport` objects, so it was possible for this race to occur:

Thread #1 | Thread #2
----------|-----------
make parent event |   
post parent event |   
  | make child event
  | post child event
  | deliver child event
deliver parent event |  

TESTED: extensive benchmarking rules out increase in wall time or heap high-water-mark.

RELNOTES: BEP events will now be written respecting parent-child ordering constraints.
PiperOrigin-RevId: 884592559
Change-Id: Iaaac7f48b849c146632fbc10ce3c2e4e1fa6af07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants