Compile native plugins into a single shared object #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… naming conflicts
fd7d849 to
b2956ba
Compare
This was referenced Jul 12, 2022
bbrto21
pushed a commit
that referenced
this pull request
Jul 13, 2022
Copy a plugin's res directory to res/[plugin_name] in the output TPK during app build. This feature has been requested by @xiaowei-guan. He wants to selectively dlopen a shared library (bundled with a plugin) depending on the current platform version at runtime. Known issue: The incremental build may fail (plugins do not rebuild) if a new lib or res file has been added after an initial build without modification to any other source file. Possible solutions include: Always force rebuild plugins (this affects the overall build time), or Support the "sharedLib" plugin type (which has been deprecated as of Compile native plugins into a single shared object #98) and let the user explicitly specify lib names in project_def.prop. (This is a partial solution since res files are not listed by project_def.prop.)
bbrto21
pushed a commit
to flutter-tizen/engine
that referenced
this pull request
Jul 14, 2022
Applies flutter#30760 to the Tizen embedder. This is an actual fix for flutter-tizen/flutter-tizen#90, which has been worked around by flutter-tizen/flutter-tizen#98. We can now support the old-fashioned "sharedLib" style plugins (each plugin is built into an individual shared object) based on this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Before]
PluginRegistrarManagerinstance and tries to register its destruction handler to the embedder.[After]
libflutter_plugins.soregardless of the app type.Changelog:
TizenPluginsbuild targetDotnetTpk.build()andNativeTpk.build()accordingly and clean upTizenLibraryclass and merge it withTizenPluginbuild/tizentobuild/tizen/tpk)__FILE__with__MODULE__intemplates/plugin/cpp/src/log.h.tmplFixes #90.