This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider] Replace path_provider_linux widget tests with simple unit tests#3812
Merged
stuartmorgan-g merged 1 commit intoApr 19, 2021
Conversation
blasten
approved these changes
Apr 19, 2021
blasten
left a comment
There was a problem hiding this comment.
Thanks! I was looking into this issue as well
Contributor
Author
|
Landing on red since the removed test is the reason submit-queue is red. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 19, 2021
Contributor
|
Thanks for deflaking these!! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 19, 2021
bhaveshptl
pushed a commit
to bhaveshptl/plugins
that referenced
this pull request
Apr 23, 2021
* master: (397 commits) [in_app_purchase] Implementation of platform interface (flutter-team-archive#3781) [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter-team-archive#3819) [tools] fix version check command not working for new packages (flutter-team-archive#3818) [camera] android-rework part 1: Base classes to support Android Camera features (flutter-team-archive#3795) fix MD (flutter-team-archive#3815) Path provider windows crash fix (flutter-team-archive#3814) [local_auth] docs update (flutter-team-archive#3103) Update PULL_REQUEST_TEMPLATE.md (flutter-team-archive#3801) [quick_actions] handle cold start on iOS correctly (flutter-team-archive#3811) Replace path_provider_linux widget tests with simple unit tests (flutter-team-archive#3812) [sensors] format dart code based on the new dart formatter (flutter-team-archive#3809) [google_sign_in] Fix "pick account" on iOS (flutter-team-archive#3805) [image_picker_platform_interface] Added pickMultiImage (flutter-team-archive#3782) [in_app_purchase] Added currency code and numerical price to product detail model. (flutter-team-archive#3794) [local_auth] Fix iOS crash when no localizedReason (flutter-team-archive#3780) Fix and update version checks (flutter-team-archive#3792) [in_app_purchase] Configured example app to use StoreKit Testing on iOS 14 (flutter-team-archive#3772) [local_auth] Unnecessary reassignment in example removed (flutter-team-archive#2983) [flutter_webview] Fix `allowsInlineMediaPlayback` ignored on iOS (flutter-team-archive#3791) Switch script/tools over to the new analysis options (flutter-team-archive#3777) ...
yasargil
added a commit
to yasargil/plugins
that referenced
this pull request
Apr 28, 2021
* master: (79 commits) Fix grammatical error in contributing guide (flutter-team-archive#3217) [google_sign_in_web] fix README typos. [tool] combine run and runAndExitOnError (flutter-team-archive#3827) [camera] android-rework part 2: Android auto focus feature (flutter-team-archive#3796) [in_app_purchase_platform_interface] Added additional fields to ProductDetails (flutter-team-archive#3826) Move all null safety packages' min dart sdk to 2.12.0 (flutter-team-archive#3822) [path_provider_*] code cleanup: sort directives (flutter-team-archive#3823) [in_app_purchase] Implementation of platform interface (flutter-team-archive#3781) [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter-team-archive#3819) [tools] fix version check command not working for new packages (flutter-team-archive#3818) [camera] android-rework part 1: Base classes to support Android Camera features (flutter-team-archive#3795) fix MD (flutter-team-archive#3815) Path provider windows crash fix (flutter-team-archive#3814) [local_auth] docs update (flutter-team-archive#3103) Update PULL_REQUEST_TEMPLATE.md (flutter-team-archive#3801) [quick_actions] handle cold start on iOS correctly (flutter-team-archive#3811) Replace path_provider_linux widget tests with simple unit tests (flutter-team-archive#3812) [sensors] format dart code based on the new dart formatter (flutter-team-archive#3809) [google_sign_in] Fix "pick account" on iOS (flutter-team-archive#3805) [image_picker_platform_interface] Added pickMultiImage (flutter-team-archive#3782) ...
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These widget tests have been flaky recently, and there's no reason not to just use unit tests instead.
Pre-launch Checklist
[shared_preferences]///).