Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Remove custom null safety analysis_options files#3339

Merged
fluttergithubbot merged 1 commit into
flutter-team-archive:masterfrom
amirh:remove-custom-options
Dec 16, 2020
Merged

Remove custom null safety analysis_options files#3339
fluttergithubbot merged 1 commit into
flutter-team-archive:masterfrom
amirh:remove-custom-options

Conversation

@amirh

@amirh amirh commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

Description

Custom analysis_options.yaml files were introduced in the nnbd branch to enable the null safety experiment.
This is no longer needed with the minimal sdk constraints (and our tools don't like per-package analysis options files).

This PR also:

"device_info/device_info_platform_interface"
"device_info/device_info"
"connectivity/connectivity_platform_interface"
"connectivity/connectivity"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@blasten blasten left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 16, 2020
@fluttergithubbot fluttergithubbot merged commit 5482d9a into flutter-team-archive:master Dec 16, 2020
@amirh amirh deleted the remove-custom-options branch December 16, 2020 19:33
NickalasB added a commit to NickalasB/plugins that referenced this pull request Dec 17, 2020
* master:
  [camera] Ios support documentation  (flutter-team-archive#3335)
  Remove custom null safety analysis_options files (flutter-team-archive#3339)
  [webview_flutter] Added 'allowsInlineMediaPlayback' property (flutter-team-archive#3334)
  [camera_platform_interface] Add torch definition to the FlashModes enum  (flutter-team-archive#3326)
  [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flutter-team-archive#3271)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java
#	packages/webview_flutter/lib/platform_interface.dart
#	packages/webview_flutter/pubspec.yaml
amantoux pushed a commit to amantoux/plugins that referenced this pull request Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants