Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Reland "[video_player] Set audio mix options (#2922)"#2939

Merged
cyanglaz merged 1 commit into
masterfrom
revert-2938-revert
Aug 18, 2020
Merged

Reland "[video_player] Set audio mix options (#2922)"#2939
cyanglaz merged 1 commit into
masterfrom
revert-2938-revert

Conversation

@cyanglaz

Copy link
Copy Markdown
Contributor

Reverts #2938

@dnfield

dnfield commented Aug 18, 2020

Copy link
Copy Markdown
Contributor

LGTM

@steve-rait

steve-rait commented Aug 27, 2020

Copy link
Copy Markdown

Hi, this new feature has a side effect :
In my app, when I upgrade plugin, It can't play multiple videos in the same screen by default anymore (I have a list with many items, one video player by item) (only on Android)
Indeed, this affects multiple players in the app itself (and not only sound).
I had to force VideoPlayerOptions mixWithOthers to true to let them play together again.

So it's a breaking change which need to be detailed somewhere in the doc, don't you think ?

@cyanglaz

Copy link
Copy Markdown
Contributor Author

@steve-rait This breakage is not intended. Do you mind create a github issue (https://github.com/flutter/flutter/issues/new/choose) describe the failure scenario in details? And preferably, if you could provide a sample code to reproduce the issue, that'd help us to accelerate the debugging process. :)
Feel free to tag me if you create the github issue.

Let me know if you want me to create the issue, but I'd probably need your help to describe it in more details.

@steve-rait

Copy link
Copy Markdown

Hi
Thanks for the info, let me create it, I'll do that this weekend or next week with a complete sample code to show precisely the problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants