This repository was archived by the owner on Apr 19, 2026. It is now read-only.
[web] Updated screenshots for relanding painting last placeholder#182
Merged
mdebbar merged 1 commit intoMar 10, 2021
Merged
Conversation
ferhatb
approved these changes
Mar 10, 2021
mdebbar
added a commit
to mdebbar/goldens
that referenced
this pull request
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots for PR: flutter-team-archive/engine#24905
The difference in these screenshots is the last paragraph that contains a placeholder in its own line. After checking Flutter's rendering on native platforms, this is the correct way to render them.
Rendering on macOS:
