Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix a race in the embedder accessibility unit test#9585

Merged
chinmaygarde merged 1 commit into
flutter-team-archive:masterfrom
jason-simmons:fix_embedder_a11y_test
Jun 30, 2019
Merged

Fix a race in the embedder accessibility unit test#9585
chinmaygarde merged 1 commit into
flutter-team-archive:masterfrom
jason-simmons:fix_embedder_a11y_test

Conversation

@jason-simmons

@jason-simmons jason-simmons commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@jason-simmons jason-simmons force-pushed the fix_embedder_a11y_test branch from 0b040f7 to 2d62184 Compare June 28, 2019 21:24
@chinmaygarde

chinmaygarde commented Jun 29, 2019

Copy link
Copy Markdown
Contributor

Fixes flutter/flutter#35218

cbracken
cbracken approved these changes Jun 29, 2019
View reviewed changes

@cbracken cbracken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@chinmaygarde

chinmaygarde commented Jun 30, 2019

Copy link
Copy Markdown
Contributor

Landing this on Jason's behalf as he is going to be out on vacation.

@chinmaygarde chinmaygarde merged commit b3fe3e9 into flutter-team-archive:master Jun 30, 2019
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
eb9ebb3 
…eam-archive/engine#9585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
2ac164a 
…eam-archive/engine#9585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
e16d260 
…eam-archive/engine#9585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
ada96ad 
…eam-archive/engine#9585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
862bcd4 
…eam-archive/engine#9585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
1db0db3 
…eam-archive/engine#9585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
0ddc583 
…eam-archive/engine#9585)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
05a333b 
…eam-archive/engine#9585)
This was referenced Jul 1, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
e63857c 
…eam-archive/engine#9585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
c390b43 
…eam-archive/engine#9585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
1b51d34 
…eam-archive/engine#9585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
8a51e1f 
…eam-archive/engine#9585)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
13142ce 
…eam-archive/engine#9585)
This was referenced Jul 2, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
1947684 
…eam-archive/engine#9585)
@a-siva a-siva mentioned this pull request Jul 2, 2019
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
3283160 
…eam-archive/engine#9585)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019
@engine-flutter-autoroll
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-t…
cd052c0 
…eam-archive/engine#9585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2019
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jul 3, 2019
@engine-flutter-autoroll
Roll engine ffba2f6..7d3e722 (59 commits) (#35489)
763ce63 
flutter-team-archive/engine@ffba2f6...7d3e722

git log ffba2f6..7d3e722 --no-merges --oneline
7d3e722 Roll buildroot to c5a493b. (flutter-team-archive/engine#9649)
8deeb77 make EmbeddedViewParams a unique ptr (flutter-team-archive/engine#9640)
7862af5 Roll src/third_party/skia bd3d8d39b3e7..215ff3325230 (4 commits) (flutter-team-archive/engine#9648)
a9ee687 iOS PlatformView clip path (flutter-team-archive/engine#9478)
c19b53c Roll src/third_party/skia effee2065796..bd3d8d39b3e7 (1 commits) (flutter-team-archive/engine#9647)
aeaa5ed Roll src/third_party/skia 2ef826576819..effee2065796 (1 commits) (flutter-team-archive/engine#9646)
1cc1f04 Roll src/third_party/skia f2c52efce52b..2ef826576819 (2 commits) (flutter-team-archive/engine#9645)
1c295b2 Roll src/third_party/skia 9fb7fa537d93..f2c52efce52b (1 commits) (flutter-team-archive/engine#9644)
56a3f41 Android Embedding Refactor PR31: Integrate platform views with the new embedding and the plugin shim. (flutter-team-archive/engine#9206)
8ac7cbd Fix warning about settings unavailable GN arg build_glfw_shell (flutter-team-archive/engine#9642)
f665717 Roll src/third_party/skia 21a486d04ae0..9fb7fa537d93 (21 commits) (flutter-team-archive/engine#9639)
fd24007 Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter-team-archive/engine#9638)
628b174 Fixes a plugin overwrite bug in the plugin shim system. (flutter-team-archive/engine#9589)
345d350 Added Doxyfile. (flutter-team-archive/engine#9632)
64b9eef Revert "Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (#9634)" (flutter-team-archive/engine#9637)
45e1ad2 Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter-team-archive/engine#9634)
da6475e Roll fuchsia/sdk/core/mac-amd64 from TRwIGIJLuznLNQzJk17zfboJrkErpe1XvGr0njCwemoC to byM-kyxL4bemlTYNqhKUfJfZoIUrCSzS6XzsFr4n9-MC (flutter-team-archive/engine#9629)
bee12e6 Roll fuchsia/sdk/core/mac-amd64 from MBS_xxNZ_O32DxW1bhOeJisJqYG9JY_FAtSa3ZYupg4C to TRwIGIJLuznLNQzJk17zfboJrkErpe1XvGr0njCwemoC (flutter-team-archive/engine#9626)
fea8fa6 Roll fuchsia/sdk/core/linux-amd64 from Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C to I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C (flutter-team-archive/engine#9625)
e7f8ca1 [all] add fuchsia.{net.NameLookup,posix.socket.Provider} (flutter-team-archive/engine#9546)
a72a999 Roll fuchsia/sdk/core/mac-amd64 from B-JzM_H7hG5kOIRFjmUqI3uWBAV7no8BnCTknbd2wQ4C to MBS_xxNZ_O32DxW1bhOeJisJqYG9JY_FAtSa3ZYupg4C (flutter-team-archive/engine#9624)
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-team-archive/engine#9585)
55818f6 Roll fuchsia/sdk/core/linux-amd64 from xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC to Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C (flutter-team-archive/engine#9623)
37a54f2 Roll fuchsia/sdk/core/linux-amd64 from O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC to xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC (flutter-team-archive/engine#9622)
458a764 Roll fuchsia/sdk/core/mac-amd64 from neDu8hWotIrKCQkxz1ScSJC4NoBva1_YVszr6wMbcZQC to B-JzM_H7hG5kOIRFjmUqI3uWBAV7no8BnCTknbd2wQ4C (flutter-team-archive/engine#9621)
6e7b4ca Roll fuchsia/sdk/core/linux-amd64 from gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC to O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC (flutter-team-archive/engine#9620)
e4d354d Roll src/third_party/skia 161f47dfbf6a..21a486d04ae0 (2 commits) (flutter-team-archive/engine#9619)
2802875 Roll fuchsia/sdk/core/mac-amd64 from tPyg8rqV40gsoXEhDf7VskccnbJGCh4_bZp71YOUinEC to neDu8hWotIrKCQkxz1ScSJC4NoBva1_YVszr6wMbcZQC (flutter-team-archive/engine#9618)
8e405c1 Roll fuchsia/sdk/core/mac-amd64 from UkCx2sMZsCM-w9nEuQC2TRfnJ7wjJCxsCxSDEx2uPegC to tPyg8rqV40gsoXEhDf7VskccnbJGCh4_bZp71YOUinEC (flutter-team-archive/engine#9615)
609a980 Fix uninitialized variables and put tests in flutter namespace. (flutter-team-archive/engine#9613)
9807894 Roll fuchsia/sdk/core/linux-amd64 from ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC to gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC (flutter-team-archive/engine#9612)
4e344e6 Wire up custom event loop interop for the GLFW embedder. (flutter-team-archive/engine#9089)
54c6226 Roll fuchsia/sdk/core/mac-amd64 from gyWAjP3BPfhpvHOOwaTusfA8JaGcY_UzjpoIGQnA_W0C to UkCx2sMZsCM-w9nEuQC2TRfnJ7wjJCxsCxSDEx2uPegC (flutter-team-archive/engine#9611)
c3f8cab Roll fuchsia/sdk/core/linux-amd64 from xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC to ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC (flutter-team-archive/engine#9610)
6f1a748 Document various classes in //flutter/shell/common. (flutter-team-archive/engine#9591)
4d36530 Roll fuchsia/sdk/core/mac-amd64 from 4PD6FCl4NvKCavA0AVsdKtZPB3G5K72KprkEH0mr064C to gyWAjP3BPfhpvHOOwaTusfA8JaGcY_UzjpoIGQnA_W0C (flutter-team-archive/engine#9609)
cf084bd Roll fuchsia/sdk/core/linux-amd64 from XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC to xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC (flutter-team-archive/engine#9607)
8d05400 disable mysterious failing tests (flutter-team-archive/engine#9608)
aa817a9 Roll fuchsia/sdk/core/mac-amd64 from DeTFBSaxMBfZpfK0c7CifGpJbJLOrs3WtuCOaINwmrwC to 4PD6FCl4NvKCavA0AVsdKtZPB3G5K72KprkEH0mr064C (flutter-team-archive/engine#9606)
4e988e0 Roll fuchsia/sdk/core/linux-amd64 from jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC to XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC (flutter-team-archive/engine#9605)
84ae36a Roll fuchsia/sdk/core/mac-amd64 from IMr36r3rRLs1G7T5OtCudVMoWjPcjRbYGgyDg7LSxPwC to DeTFBSaxMBfZpfK0c7CifGpJbJLOrs3WtuCOaINwmrwC (flutter-team-archive/engine#9604)
7135c8d Roll fuchsia/sdk/core/mac-amd64 from qcwCYvuT0PeU97HpvMVmC114EOKwfrk8PdFdZz_m6CIC to IMr36r3rRLs1G7T5OtCudVMoWjPcjRbYGgyDg7LSxPwC (flutter-team-archive/engine#9602)
8f4df03 Roll fuchsia/sdk/core/linux-amd64 from Y3kUPtfq2frI60zx7VssO-WG733jtODCmnESyz0UGdEC to jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC (flutter-team-archive/engine#9601)
6c6a0d7 [trace clients] Remove fuchsia.tracelink.Registry (flutter-team-archive/engine#9593)
f931539 Roll fuchsia/sdk/core/mac-amd64 from UsrGfX7Fj96MljgqUFc_A-o_ufsa_FX3eaG14ZSDWMAC to qcwCYvuT0PeU97HpvMVmC114EOKwfrk8PdFdZz_m6CIC (flutter-team-archive/engine#9600)
...
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@engine-flutter-autoroll @johnsonmh
Roll engine ffba2f6..7d3e722 (59 commits) (flutter#35489)
7ffd037 
flutter-team-archive/engine@ffba2f6...7d3e722

git log ffba2f6..7d3e722 --no-merges --oneline
7d3e722 Roll buildroot to c5a493b. (flutter-team-archive/engine#9649)
8deeb77 make EmbeddedViewParams a unique ptr (flutter-team-archive/engine#9640)
7862af5 Roll src/third_party/skia bd3d8d39b3e7..215ff3325230 (4 commits) (flutter-team-archive/engine#9648)
a9ee687 iOS PlatformView clip path (flutter-team-archive/engine#9478)
c19b53c Roll src/third_party/skia effee2065796..bd3d8d39b3e7 (1 commits) (flutter-team-archive/engine#9647)
aeaa5ed Roll src/third_party/skia 2ef826576819..effee2065796 (1 commits) (flutter-team-archive/engine#9646)
1cc1f04 Roll src/third_party/skia f2c52efce52b..2ef826576819 (2 commits) (flutter-team-archive/engine#9645)
1c295b2 Roll src/third_party/skia 9fb7fa537d93..f2c52efce52b (1 commits) (flutter-team-archive/engine#9644)
56a3f41 Android Embedding Refactor PR31: Integrate platform views with the new embedding and the plugin shim. (flutter-team-archive/engine#9206)
8ac7cbd Fix warning about settings unavailable GN arg build_glfw_shell (flutter-team-archive/engine#9642)
f665717 Roll src/third_party/skia 21a486d04ae0..9fb7fa537d93 (21 commits) (flutter-team-archive/engine#9639)
fd24007 Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter-team-archive/engine#9638)
628b174 Fixes a plugin overwrite bug in the plugin shim system. (flutter-team-archive/engine#9589)
345d350 Added Doxyfile. (flutter-team-archive/engine#9632)
64b9eef Revert &flutter#34;Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter#9634)&flutter#34; (flutter-team-archive/engine#9637)
45e1ad2 Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter-team-archive/engine#9634)
da6475e Roll fuchsia/sdk/core/mac-amd64 from TRwIGIJLuznLNQzJk17zfboJrkErpe1XvGr0njCwemoC to byM-kyxL4bemlTYNqhKUfJfZoIUrCSzS6XzsFr4n9-MC (flutter-team-archive/engine#9629)
bee12e6 Roll fuchsia/sdk/core/mac-amd64 from MBS_xxNZ_O32DxW1bhOeJisJqYG9JY_FAtSa3ZYupg4C to TRwIGIJLuznLNQzJk17zfboJrkErpe1XvGr0njCwemoC (flutter-team-archive/engine#9626)
fea8fa6 Roll fuchsia/sdk/core/linux-amd64 from Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C to I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C (flutter-team-archive/engine#9625)
e7f8ca1 [all] add fuchsia.{net.NameLookup,posix.socket.Provider} (flutter-team-archive/engine#9546)
a72a999 Roll fuchsia/sdk/core/mac-amd64 from B-JzM_H7hG5kOIRFjmUqI3uWBAV7no8BnCTknbd2wQ4C to MBS_xxNZ_O32DxW1bhOeJisJqYG9JY_FAtSa3ZYupg4C (flutter-team-archive/engine#9624)
b3fe3e9 Fix a race in the embedder accessibility unit test (flutter-team-archive/engine#9585)
55818f6 Roll fuchsia/sdk/core/linux-amd64 from xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC to Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C (flutter-team-archive/engine#9623)
37a54f2 Roll fuchsia/sdk/core/linux-amd64 from O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC to xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC (flutter-team-archive/engine#9622)
458a764 Roll fuchsia/sdk/core/mac-amd64 from neDu8hWotIrKCQkxz1ScSJC4NoBva1_YVszr6wMbcZQC to B-JzM_H7hG5kOIRFjmUqI3uWBAV7no8BnCTknbd2wQ4C (flutter-team-archive/engine#9621)
6e7b4ca Roll fuchsia/sdk/core/linux-amd64 from gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC to O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC (flutter-team-archive/engine#9620)
e4d354d Roll src/third_party/skia 161f47dfbf6a..21a486d04ae0 (2 commits) (flutter-team-archive/engine#9619)
2802875 Roll fuchsia/sdk/core/mac-amd64 from tPyg8rqV40gsoXEhDf7VskccnbJGCh4_bZp71YOUinEC to neDu8hWotIrKCQkxz1ScSJC4NoBva1_YVszr6wMbcZQC (flutter-team-archive/engine#9618)
8e405c1 Roll fuchsia/sdk/core/mac-amd64 from UkCx2sMZsCM-w9nEuQC2TRfnJ7wjJCxsCxSDEx2uPegC to tPyg8rqV40gsoXEhDf7VskccnbJGCh4_bZp71YOUinEC (flutter-team-archive/engine#9615)
609a980 Fix uninitialized variables and put tests in flutter namespace. (flutter-team-archive/engine#9613)
9807894 Roll fuchsia/sdk/core/linux-amd64 from ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC to gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC (flutter-team-archive/engine#9612)
4e344e6 Wire up custom event loop interop for the GLFW embedder. (flutter-team-archive/engine#9089)
54c6226 Roll fuchsia/sdk/core/mac-amd64 from gyWAjP3BPfhpvHOOwaTusfA8JaGcY_UzjpoIGQnA_W0C to UkCx2sMZsCM-w9nEuQC2TRfnJ7wjJCxsCxSDEx2uPegC (flutter-team-archive/engine#9611)
c3f8cab Roll fuchsia/sdk/core/linux-amd64 from xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC to ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC (flutter-team-archive/engine#9610)
6f1a748 Document various classes in //flutter/shell/common. (flutter-team-archive/engine#9591)
4d36530 Roll fuchsia/sdk/core/mac-amd64 from 4PD6FCl4NvKCavA0AVsdKtZPB3G5K72KprkEH0mr064C to gyWAjP3BPfhpvHOOwaTusfA8JaGcY_UzjpoIGQnA_W0C (flutter-team-archive/engine#9609)
cf084bd Roll fuchsia/sdk/core/linux-amd64 from XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC to xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC (flutter-team-archive/engine#9607)
8d05400 disable mysterious failing tests (flutter-team-archive/engine#9608)
aa817a9 Roll fuchsia/sdk/core/mac-amd64 from DeTFBSaxMBfZpfK0c7CifGpJbJLOrs3WtuCOaINwmrwC to 4PD6FCl4NvKCavA0AVsdKtZPB3G5K72KprkEH0mr064C (flutter-team-archive/engine#9606)
4e988e0 Roll fuchsia/sdk/core/linux-amd64 from jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC to XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC (flutter-team-archive/engine#9605)
84ae36a Roll fuchsia/sdk/core/mac-amd64 from IMr36r3rRLs1G7T5OtCudVMoWjPcjRbYGgyDg7LSxPwC to DeTFBSaxMBfZpfK0c7CifGpJbJLOrs3WtuCOaINwmrwC (flutter-team-archive/engine#9604)
7135c8d Roll fuchsia/sdk/core/mac-amd64 from qcwCYvuT0PeU97HpvMVmC114EOKwfrk8PdFdZz_m6CIC to IMr36r3rRLs1G7T5OtCudVMoWjPcjRbYGgyDg7LSxPwC (flutter-team-archive/engine#9602)
8f4df03 Roll fuchsia/sdk/core/linux-amd64 from Y3kUPtfq2frI60zx7VssO-WG733jtODCmnESyz0UGdEC to jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC (flutter-team-archive/engine#9601)
6c6a0d7 [trace clients] Remove fuchsia.tracelink.Registry (flutter-team-archive/engine#9593)
f931539 Roll fuchsia/sdk/core/mac-amd64 from UsrGfX7Fj96MljgqUFc_A-o_ufsa_FX3eaG14ZSDWMAC to qcwCYvuT0PeU97HpvMVmC114EOKwfrk8PdFdZz_m6CIC (flutter-team-archive/engine#9600)
...
@cbracken cbracken mentioned this pull request Oct 25, 2019
Merged
cbracken added a commit that referenced this pull request Oct 25, 2019
@cbracken
Remove TODO on embedder a11y unit tests (#13346)
29b1725 
Removes a TODO implying that the embedder accessibility unittests were
disabled due to flakiness.

The tests were originally disabled in
#9482.

The issue tracking re-enabling the tests was
flutter/flutter#35218.

This issue was resolved, and the tests re-enabled, in
#9585.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@chinmaygarde chinmaygarde chinmaygarde approved these changes
@cbracken cbracken cbracken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jason-simmons @chinmaygarde @cbracken @googlebot