This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Document that all MethodChannel callbacks must be called on the main thread.#6245
Merged
Merged
Conversation
…thread. This further addresses flutter/flutter#14568.
jason-simmons
approved these changes
Sep 13, 2018
| * interface for handling results received from Flutter. | ||
| * | ||
| * <p>All methods of this class must be called on the platform thread (Android main thread). For more details see | ||
| * <a href="https://github.com/flutter/engine/wiki/Threading-in-the-Flutter-Engine">Threading in the Flutter |
Contributor
There was a problem hiding this comment.
We should add a check for invocation of nativeInvokePlatformMessageResponseCallback on the wrong thread. Or have the BinaryReply object run the reply action on the platform thread.
Contributor
|
Can this be committed? |
jason-simmons
approved these changes
Sep 27, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 28, 2018
flutter-team-archive/engine@d80c1de...8176f4d git log d80c1de..8176f4d --no-merges --oneline 8176f4d Roll buildroot to 96d2493 (flutter-team-archive/engine#6364) 27f77cb Document that all MethodChannel callbacks must be called on the main thread. (flutter-team-archive/engine#6245) e6c1733 Script to verify exported symbols on release binaries (flutter-team-archive/engine#6363) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 28, 2018
flutter-team-archive/engine@d80c1de...8176f4d git log d80c1de..8176f4d --no-merges --oneline 8176f4d Roll buildroot to 96d2493 (flutter-team-archive/engine#6364) 27f77cb Document that all MethodChannel callbacks must be called on the main thread. (flutter-team-archive/engine#6245) e6c1733 Script to verify exported symbols on release binaries (flutter-team-archive/engine#6363) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
GaryQian
pushed a commit
to GaryQian/engine
that referenced
this pull request
Oct 2, 2018
…thread. (flutter-team-archive#6245) This further addresses flutter/flutter#14568.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This further addresses flutter/flutter#14568.
This aspect was not immediately obvious to my team as a Flutter user and led me to inspecting the implementation, so I figured documenting this in-place would be useful.