This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Delete last usages of MockCanvas test mechanism#55840
Merged
auto-submit[bot] merged 3 commits intoOct 12, 2024
Merged
Conversation
1b4f500 to
9067ffb
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 12, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 12, 2024
flutter-team-archive/engine@b39fec6...ea311c9 2024-10-12 zanderso@users.noreply.github.com Roll buildroot for flutter-team-archive/buildroot#912 (flutter-team-archive/engine#55818) 2024-10-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from d916a5f69a48 to 75bf9e183a33 (1 revision) (#55838)" (flutter-team-archive/engine#55850) 2024-10-12 flar@google.com Delete last usages of MockCanvas test mechanism (flutter-team-archive/engine#55840) 2024-10-12 skia-flutter-autoroll@skia.org Roll Skia from 97cebfb06139 to d2833b68c8c7 (9 revisions) (flutter-team-archive/engine#55846) 2024-10-12 jonahwilliams@google.com [Impeller] delete a bunch of dead filter code. (flutter-team-archive/engine#55841) 2024-10-12 55750689+AthulJoseph27@users.noreply.github.com [Impeller] Added support to set polygon mode in Flutter GPU. (flutter-team-archive/engine#55804) 2024-10-11 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d916a5f69a48 to 75bf9e183a33 (1 revision) (flutter-team-archive/engine#55838) 2024-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1OZ2rHDklRNSZRUrc... to tNuwSyjjbdU9HjOwQ... (flutter-team-archive/engine#55837) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 1OZ2rHDklRNS to tNuwSyjjbdU9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…/engine#55840) The MockCanvas API was originally used to test the output of rendering methods to match them against a reference set of "MockData" structures. This API has been superseded by just using a DisplayListBuilder to record reference operations and then to compare the resulting DisplayList objects. This PR deletes the last remaining uses of MockCanvas as well as the mechanism itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MockCanvas API was originally used to test the output of rendering methods to match them against a reference set of "MockData" structures. This API has been superseded by just using a DisplayListBuilder to record reference operations and then to compare the resulting DisplayList objects.
This PR deletes the last remaining uses of MockCanvas as well as the mechanism itself.