This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Eliminate archive_gen_snapshot target#53948
Merged
auto-submit[bot] merged 1 commit intoJul 16, 2024
Merged
Conversation
This target produced an unused zipfile named `gen_snapshot.zip`
containing the `gen_snapshot_${target_arch}` binary for the current
build's target architecture.
The macOS recipe JSON produces the real `gen_snapshot.zip` that gets
uploaded to the cloud bucket and pulled down by the tool. See:
https://github.com/flutter/engine/blob/e5215e6854bc61cf8d5bae48715d73293bc1f91c/ci/builders/mac_host_engine.json#L555-L592
The recipe did, however, rely on the `archive_gen_snapshot` rule to
ensure that the underlying `gen_snapshot` targets were actually built.
See, for example:
https://github.com/flutter/engine/blob/e5215e6854bc61cf8d5bae48715d73293bc1f91c/ci/builders/mac_host_engine.json#L45
A few benefits:
* Eliminates an unnecessary zip operation.
* Eliminates confusion from grepping for gen_snapshot.zip and finding
the wrong location in the source.
* Grepping for create_macos_gen_snapshots will turn up the usage in the
JSON build file.
zanderso
approved these changes
Jul 16, 2024
zanderso
left a comment
Contributor
There was a problem hiding this comment.
LGTM and to clarify, this only eliminates the unused .zip file, but the recipe is still not yet using the lipo'd gen_snapshots, correct?
Contributor
Author
|
Yep - that's exactly correct. This is just a cleanup of dead code so the next person who has to deal with this archive has it easier. |
Contributor
Author
|
And I mean, if we're being realistic, the next person to deal with this is probably one of the people on this patch. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 17, 2024
…1868) Manual roll requested by zra@google.com flutter-team-archive/engine@5b9fc4e...b2bdd68 2024-07-16 bdero@google.com [Impeller] Use depth transform in framebuffer blend entities. (flutter-team-archive/engine#53951) 2024-07-16 chris@bracken.jp [macOS] Eliminate archive_gen_snapshot target (flutter-team-archive/engine#53948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…tter#151868) Manual roll requested by zra@google.com flutter-team-archive/engine@5b9fc4e...b2bdd68 2024-07-16 bdero@google.com [Impeller] Use depth transform in framebuffer blend entities. (flutter-team-archive/engine#53951) 2024-07-16 chris@bracken.jp [macOS] Eliminate archive_gen_snapshot target (flutter-team-archive/engine#53948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…tter#151868) Manual roll requested by zra@google.com flutter-team-archive/engine@5b9fc4e...b2bdd68 2024-07-16 bdero@google.com [Impeller] Use depth transform in framebuffer blend entities. (flutter-team-archive/engine#53951) 2024-07-16 chris@bracken.jp [macOS] Eliminate archive_gen_snapshot target (flutter-team-archive/engine#53948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This target produced an unused zipfile named
gen_snapshot.zipcontaining thegen_snapshot_${target_arch}binary for the current build's target architecture.The macOS recipe JSON produces the real
gen_snapshot.zipthat gets uploaded to the cloud bucket and pulled down by the tool. See: https://github.com/flutter/engine/blob/e5215e6854bc61cf8d5bae48715d73293bc1f91c/ci/builders/mac_host_engine.json#L555-L592The recipe did, however, rely on the
archive_gen_snapshotrule to ensure that the underlyinggen_snapshottargets were actually built. See, for example:https://github.com/flutter/engine/blob/e5215e6854bc61cf8d5bae48715d73293bc1f91c/ci/builders/mac_host_engine.json#L45
A few benefits:
Issue: flutter/flutter#151848
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.