This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Prevent solo: true from being committed"#51858
Merged
Merged
Conversation
This reverts commit 4e6692c.
Contributor
Author
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 3, 2024
flutter-team-archive/engine@e603f89...0da1b2e 2024-04-03 zanderso@users.noreply.github.com Revert "Prevent `solo: true` from being committed" (flutter-team-archive/engine#51858) 2024-04-03 skia-flutter-autoroll@skia.org Roll Dart SDK from e6e6d5fe3fb0 to 091dd9120d35 (4 revisions) (flutter-team-archive/engine#51845) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #51712
Reason for revert: As discussed in flutter/flutter#143312, and in https://discord.com/channels/608014603317936148/1224499330824802375. I apologize if this seems hasty and not fully justified, but it is important that the engine repo follows policies like this to make it easier for our various teams to work together.