Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add a similar runIf guard to web_engine as web framework.#50846

Merged
matanlurey merged 1 commit into
flutter-team-archive:mainfrom
matanlurey:engine-web-runIf
Feb 22, 2024
Merged

Add a similar runIf guard to web_engine as web framework.#50846
matanlurey merged 1 commit into
flutter-team-archive:mainfrom
matanlurey:engine-web-runIf

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

Right now web_engine builders are run unconditionally, which seems unnecessary.

@matanlurey matanlurey merged commit be9a8e5 into flutter-team-archive:main Feb 22, 2024
@matanlurey matanlurey deleted the engine-web-runIf branch February 22, 2024 00:56
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Feb 22, 2024
flutter-team-archive/engine@bf5c003...7eeb697

2024-02-22 tugorez@users.noreply.github.com Add view focus direction detection to flutter web. (flutter-team-archive/engine#50843)
2024-02-22 matanlurey@users.noreply.github.com Add a similar `runIf` guard to `web_engine` as web framework. (flutter-team-archive/engine#50846)
2024-02-22 dkwingsmt@users.noreply.github.com Add scheduleWarmUpFrame (flutter-team-archive/engine#50570)
2024-02-22 matanlurey@users.noreply.github.com Remove/reduce unused or private methods and add tests to `SkiaGoldClient` (flutter-team-archive/engine#50844)
2024-02-22 matanlurey@users.noreply.github.com Clean up contributing formatting, add a Skia gold callout (flutter-team-archive/engine#50828)
2024-02-21 34871572+gmackall@users.noreply.github.com Make Android Studio be able to run android embedding unit tests out of the box (flutter-team-archive/engine#50840)
2024-02-21 zanderso@users.noreply.github.com Shift some deps to //flutter/third_party (flutter-team-archive/engine#50830)
2024-02-21 tugorez@users.noreply.github.com Make the view focus binding report focus transitions across elements. (flutter-team-archive/engine#50610)
2024-02-21 chris@bracken.jp [macOS] Wrap FlutterEngineTest in autoreleasepool (flutter-team-archive/engine#50832)
2024-02-21 jason-simmons@users.noreply.github.com Update the vulkan_glfw sample for the latest roll of vulkan-deps (flutter-team-archive/engine#50839)
2024-02-21 skia-flutter-autoroll@skia.org Roll Skia from 8fa858855820 to 57490c8d257e (6 revisions) (flutter-team-archive/engine#50833)
2024-02-21 zanderso@users.noreply.github.com Starts a .ci.yaml parser (flutter-team-archive/engine#50783)
2024-02-21 skia-flutter-autoroll@skia.org Roll Dart SDK from f344e2266468 to 0f0f7400c38a (6 revisions) (flutter-team-archive/engine#50837)
2024-02-21 737941+loic-sharma@users.noreply.github.com [Windows] Fix top-level message procedure order (flutter-team-archive/engine#50797)
2024-02-21 john@johnmccutchan.com Tweak verbose log messages in ImageReaderSurfaceProducer (flutter-team-archive/engine#50831)
2024-02-21 matanlurey@users.noreply.github.com Add a throw statement for imgtestAdd non 0 exit codes. (flutter-team-archive/engine#50829)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants