Run engine unit tests on mac host_debug_unopt_arm64 by zanderso · Pull Request #50327 · flutter-team-archive/engine

zanderso · 2024-02-03T19:10:03Z

zanderso · 2024-02-07T04:11:56Z

Copying this out before I hit retry: From: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/689309/overview

[ RUN      ] Play/BlitPassTest.BlitAcrossDifferentPixelFormatsFails/Metal
-[MTLDebugDevice newTextureWithDescriptor:]:1017: failed assertion `Texture Descriptor Validation
Memoryless texture need to have renderable PixelFormat.

chinmaygarde · 2024-02-08T21:14:41Z

Can we file issues for the failing validations?

jonahwilliams · 2024-02-20T22:57:51Z

I'm just going to push fixes to this PR.

jonahwilliams · 2024-02-21T18:25:02Z

@zanderso I think the remaining failure is a builder config problem?

Running command "python3 test.py"
Traceback (most recent call last):
  File "test.py", line 51, in <module>
    raise Exception(
Exception: Could not locate font-subset in host_debug or host_debug_unopt - build before running this script.

jonahwilliams · 2024-02-21T18:25:13Z

See also: flutter/flutter#143324

zanderso · 2024-02-21T23:27:35Z

@zanderso I think the remaining failure is a builder config problem?

Yeah, that looks like the font-subset test script is hardcoding some strings that should be arguments instead. I can take a look at that.

zanderso · 2024-02-22T04:39:04Z

I've cleaned up an fixed the font-subset test script. The last remaining failure is EmbedderTest.CompositorMustBeAbleToRenderKnownSceneWithSoftwareCompositor, which I'm not sure how to address. It looks like an ad-hoc pixel test.

I filed flutter/flutter#143940

jonahwilliams

LGTM, thanks @zanderso !

jonahwilliams

Actually you blew away my patch to fix the test by force pushing.

zanderso · 2024-02-26T20:26:29Z

Actually you blew away my patch to fix the test by force pushing.

Ooooops

jonahwilliams · 2024-02-26T20:28:13Z

The fix is to change the failing test to the following:

TEST_P(BlitPassTest, BlitAcrossDifferentPixelFormatsFails) {
  ScopedValidationDisable scope;  // avoid noise in output.
  auto context = GetContext();
  auto cmd_buffer = context->CreateCommandBuffer();
  auto blit_pass = cmd_buffer->CreateBlitPass();

  TextureDescriptor src_desc;
  src_desc.format = PixelFormat::kA8UNormInt;
  src_desc.size = {100, 100};
  src_desc.storage_mode = StorageMode::kHostVisible;
  auto src = context->GetResourceAllocator()->CreateTexture(src_desc);

  TextureDescriptor dst_format;
  dst_format.format = PixelFormat::kR8G8B8A8UNormInt;
  dst_format.size = {100, 100};
  dst_format.storage_mode = StorageMode::kHostVisible;
  auto dst = context->GetResourceAllocator()->CreateTexture(dst_format);

  EXPECT_FALSE(blit_pass->AddCopy(src, dst));
}

…team-archive/engine#50327)

flutter-team-archive/engine@04ff286...0bc21ea 2024-02-27 matanlurey@users.noreply.github.com Respect SIGINT (Ctrl-C) for Android scenario_app. (flutter-team-archive/engine#50989) 2024-02-27 skia-flutter-autoroll@skia.org Roll Skia from aa28c3a30a98 to 2f2a718b27f7 (1 revision) (flutter-team-archive/engine#50998) 2024-02-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 2876f5684ced to 67b2a250747b (1 revision) (flutter-team-archive/engine#50996) 2024-02-27 matanlurey@users.noreply.github.com Fix usage of `--out-dir` with a relative path. (flutter-team-archive/engine#50992) 2024-02-27 jason-simmons@users.noreply.github.com Roll buildroot to 21b1b9f2645fada701885108e86aefbcb3b1cca0 (flutter-team-archive/engine#50991) 2024-02-27 skia-flutter-autoroll@skia.org Roll Skia from ba3ed5998af3 to aa28c3a30a98 (12 revisions) (flutter-team-archive/engine#50994) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate Android `scenario_app` to the `SurfaceProducer` API (#50993)" (flutter-team-archive/engine#50995) 2024-02-27 matanlurey@users.noreply.github.com Migrate Android `scenario_app` to the `SurfaceProducer` API (flutter-team-archive/engine#50993) 2024-02-27 dkwingsmt@users.noreply.github.com Revert "Reland 4: Multiview pipeline (#50931)" (flutter-team-archive/engine#50985) 2024-02-26 matanlurey@users.noreply.github.com Refactor args parsing/environment constructor for `scenario_app` (flutter-team-archive/engine#50980) 2024-02-26 jonahwilliams@google.com [scenario] trigger firstFrameLatch on exception. (flutter-team-archive/engine#50981) 2024-02-26 jason-simmons@users.noreply.github.com [Impeller] Fix a misspelling and name mismatch in a shader test fixture (flutter-team-archive/engine#50983) 2024-02-26 skia-flutter-autoroll@skia.org Roll Dart SDK from c479735adcf9 to 2876f5684ced (2 revisions) (flutter-team-archive/engine#50979) 2024-02-26 zanderso@users.noreply.github.com Run engine unit tests on mac host_debug_unopt_arm64 (flutter-team-archive/engine#50327) 2024-02-26 jonahwilliams@google.com [Impeller] disble render pass caches. (flutter-team-archive/engine#50976) 2024-02-26 john@johnmccutchan.com Update Surface reference after resizing render target in VirtualDisplay based platform views (flutter-team-archive/engine#50971) 2024-02-26 jason-simmons@users.noreply.github.com [Impeller] Fix a race that can abort the process if the Vulkan context is destroyed while pipeline creation tasks are pending (flutter-team-archive/engine#50883) 2024-02-26 matanlurey@users.noreply.github.com Better filtering for Android `scenario_app` runner. (flutter-team-archive/engine#50937) 2024-02-26 jacksongardner@google.com Make sure to call `setHeightOverride` as well on TextStyle and StrutStyle (flutter-team-archive/engine#50920) 2024-02-26 jacksongardner@google.com Correctly offset the cull rect of the opacity layer. (flutter-team-archive/engine#50928) 2024-02-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kLvCWEgbL1VTRW69e... to JCdhkDSFXzHyPuP4I... (flutter-team-archive/engine#50970) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from kLvCWEgbL1VT to JCdhkDSFXzHy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

zanderso force-pushed the impeller-unittests-m1 branch from 77cff67 to dae4259 Compare February 3, 2024 19:22

zanderso force-pushed the impeller-unittests-m1 branch from 40b5df4 to 6fc8824 Compare February 8, 2024 15:42

zanderso force-pushed the impeller-unittests-m1 branch from 6fc8824 to 73a3a81 Compare February 20, 2024 19:22

jonahwilliams self-requested a review February 20, 2024 19:23

github-actions Bot added the e: impeller label Feb 20, 2024

zanderso force-pushed the impeller-unittests-m1 branch 2 times, most recently from 1245e4b to 0cd3fa1 Compare February 22, 2024 04:07

zanderso mentioned this pull request Feb 22, 2024

EmbedderTest.CompositorMustBeAbleToRenderKnownSceneWithSoftwareCompositor fails on arm64 mac hardware in CI flutter/flutter#143940

Open

zanderso force-pushed the impeller-unittests-m1 branch 2 times, most recently from ed5cd34 to 651fb5e Compare February 26, 2024 20:02

jonahwilliams approved these changes Feb 26, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

jonahwilliams reviewed Feb 26, 2024

View reviewed changes

Run engine unit tests on mac host_debug_unopt_arm64

6055d7b

zanderso force-pushed the impeller-unittests-m1 branch from 651fb5e to 6055d7b Compare February 26, 2024 20:31

zanderso merged commit c247449 into flutter-team-archive:main Feb 26, 2024

zanderso deleted the impeller-unittests-m1 branch February 26, 2024 21:39

engine-flutter-autoroll mentioned this pull request Feb 26, 2024

Roll Flutter Engine from 04ff2868ce80 to c24744983bc1 (8 revisions) flutter/flutter#144188

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 26, 2024

c247449 Run engine unit tests on mac host_debug_unopt_arm64 (flutter-…

034cd9c

…team-archive/engine#50327)

engine-flutter-autoroll mentioned this pull request Feb 27, 2024

Roll Flutter Engine from 04ff2868ce80 to 070290bbae0a (12 revisions) flutter/flutter#144192

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2024

c247449 Run engine unit tests on mac host_debug_unopt_arm64 (flutter-…

0472207

…team-archive/engine#50327)

engine-flutter-autoroll mentioned this pull request Feb 27, 2024

Roll Flutter Engine from 04ff2868ce80 to 924d5db87d4f (13 revisions) flutter/flutter#144200

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2024

c247449 Run engine unit tests on mac host_debug_unopt_arm64 (flutter-…

275644c

…team-archive/engine#50327)

engine-flutter-autoroll mentioned this pull request Feb 27, 2024

Roll Flutter Engine from 04ff2868ce80 to 6965435111ef (19 revisions) flutter/flutter#144206

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2024

c247449 Run engine unit tests on mac host_debug_unopt_arm64 (flutter-…

8175654

…team-archive/engine#50327)

engine-flutter-autoroll mentioned this pull request Feb 27, 2024

Roll Flutter Engine from 04ff2868ce80 to 0bc21ea7bc92 (21 revisions) flutter/flutter#144208

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2024

c247449 Run engine unit tests on mac host_debug_unopt_arm64 (flutter-…

254c6e0

…team-archive/engine#50327)

selfisekai mentioned this pull request Mar 19, 2024

engine: misleading exception message in font_subset test script flutter/flutter#145412

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Run engine unit tests on mac host_debug_unopt_arm64#50327

Run engine unit tests on mac host_debug_unopt_arm64#50327
zanderso merged 1 commit into
flutter-team-archive:mainfrom
zanderso:impeller-unittests-m1

zanderso commented Feb 3, 2024

Uh oh!

zanderso commented Feb 7, 2024 •

edited

Loading

Uh oh!

chinmaygarde commented Feb 8, 2024

Uh oh!

jonahwilliams commented Feb 20, 2024

Uh oh!

jonahwilliams commented Feb 21, 2024

Uh oh!

jonahwilliams commented Feb 21, 2024

Uh oh!

zanderso commented Feb 21, 2024

Uh oh!

zanderso commented Feb 22, 2024 •

edited

Loading

Uh oh!

jonahwilliams left a comment

Uh oh!

This comment was marked as outdated.

jonahwilliams left a comment

Uh oh!

zanderso commented Feb 26, 2024

Uh oh!

jonahwilliams commented Feb 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

zanderso commented Feb 3, 2024

Uh oh!

zanderso commented Feb 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chinmaygarde commented Feb 8, 2024

Uh oh!

jonahwilliams commented Feb 20, 2024

Uh oh!

jonahwilliams commented Feb 21, 2024

Uh oh!

jonahwilliams commented Feb 21, 2024

Uh oh!

zanderso commented Feb 21, 2024

Uh oh!

zanderso commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

zanderso commented Feb 26, 2024

Uh oh!

jonahwilliams commented Feb 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

zanderso commented Feb 7, 2024 •

edited

Loading

zanderso commented Feb 22, 2024 •

edited

Loading