Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] updated ios benchmark link#47515

Merged
gaaclarke merged 1 commit into
flutter-team-archive:mainfrom
gaaclarke:update-benchmark-ios
Oct 31, 2023
Merged

[Impeller] updated ios benchmark link#47515
gaaclarke merged 1 commit into
flutter-team-archive:mainfrom
gaaclarke:update-benchmark-ios

Conversation

@gaaclarke

Copy link
Copy Markdown
Contributor

This md references new_gallery_impeller_ios__transition_perf which is no longer updated.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke gaaclarke merged commit e666257 into flutter-team-archive:main Oct 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2023
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Nov 1, 2023
flutter-team-archive/engine@406b7d7...db06c2e

2023-10-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rg_Ici1tgAVF93cn9... to x2NzYMNhyodIwDl0I... (flutter-team-archive/engine#47528)
2023-10-31 30870216+gaaclarke@users.noreply.github.com [Impeller] updated ios benchmark link (flutter-team-archive/engine#47515)
2023-10-31 30870216+gaaclarke@users.noreply.github.com Made clang tidy use arm64 if on an arm64 mac. (flutter-team-archive/engine#47494)
2023-10-31 bdero@google.com [Impeller] Allow 3D scenes to render when MSAA is not supported. (flutter-team-archive/engine#47217)
2023-10-31 matanlurey@users.noreply.github.com Surgically remove `.*dither.*` from the Engine (flutter-team-archive/engine#46750)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from rg_Ici1tgAVF to x2NzYMNhyodI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants