…-archive/engine#44335)

flutter-team-archive/engine@b08e141...0c1de9b

2023-08-03 yjbanov@google.com [web] fix clicks on merged semantic nodes
(flutter-team-archive/engine#43620)
2023-08-03 john@johnmccutchan.com Remove WARNINGs from JNI load path as
we can't suppress them (flutter-team-archive/engine#44348)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 872dc53233cf to
bae32428c1c7 (3 revisions) (flutter-team-archive/engine#44341)
2023-08-03 ychris@google.com Build iOS unittest target in unopt builds
(flutter-team-archive/engine#44301)
2023-08-03 chris@bracken.jp [darwin] Move common targets to
common/BUILD.gn (flutter-team-archive/engine#44335)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 2babe68de295 to
872dc53233cf (2 revisions) (flutter-team-archive/engine#44339)
2023-08-03 kjlubick@users.noreply.github.com Migrate GL calls of
GrBackend* (flutter-team-archive/engine#44334)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 36072a994f11 to
2babe68de295 (1 revision) (flutter-team-archive/engine#44336)
2023-08-03 skia-flutter-autoroll@skia.org Roll Clang from 07c592048780
to 020d2fb7711d (flutter-team-archive/engine#44332)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

…#44335)

Previously, some common Darwin framework targets existed in: 
//flutter/shell/platform/darwin/BUILD.gn

This moves all targets into:
//flutter/shell/platform/darwin/common/BUILD.gn

The framework_shared target has been renamed framework_common for consistency with the directory name, and flutter_channels_unittests has been renamed framework_common_unittests since it's a reasonable target for adding other tests of common framework code.

We also de-duplicate targets with existing targets.
* The `flutter_channels` target duplicates the existing
`framework_shared` target.
* The `common` target already includes the buffer conversions
translation units,
  which are only used by the iOS embedder.

No test changes since there are no semantic changes, just a
restructuring of build targets.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat