Specify allowed Macmini models by zanderso · Pull Request #41219 · flutter-team-archive/engine

zanderso · 2023-04-14T19:58:18Z

This excludes Macmini7,1.

This excludes Macmini7,1. Fixes flutter/flutter#124877

zanderso · 2023-04-14T19:59:51Z

It looks like a string is expected, not a map:

FormatException: Protobuf JSON decoding failed at: root["platform_properties"]["mac"]["properties"]["dimensions"]. Expected String value

godofredoc · 2023-04-14T20:10:12Z

It looks like a string is expected, not a map:

FormatException: Protobuf JSON decoding failed at: root["platform_properties"]["mac"]["properties"]["dimensions"]. Expected String value

The error is coming from the .ci.yaml proto https://cs.opensource.google/flutter/cocoon/+/main:app_dart/lib/src/model/ci_yaml/target.dart;l=40, seems like some changes are going to be needed in the cocoon scheduler.

godofredoc · 2023-04-14T20:28:06Z

      xcode: 14a5294e # xcode 14.0 beta 5
+      dimensions:
+        mac_model: >-
+          ["Macmini8,1", "Macmini9.1"]


It seems like mac_model: "Macmini8,1|Macmini9.1" would do the trick

dnfield · 2023-04-14T20:31:28Z

      os: Mac-12
      xcode: 14a5294e # xcode 14.0 beta 5
+    dimensions:
+      mac_model: "Macmini8,1|Macmini9.1"


Suggested change

mac_model: "Macmini8,1|Macmini9.1"

mac_model: "Macmini8,1|Macmini9,1"

godofredoc · 2023-04-14T20:47:37Z

Seems like things are working as expected:

godofredoc

Thanks for the change!

zanderso · 2023-04-14T20:50:28Z

👍🏻 No worries. It would be great if this could be self-service, but I think the documentation needs a lot of improvements before that's realistic.

ricardoamador

LGTM

ricardoamador · 2023-04-14T20:52:00Z

@zanderso are you referring to the ciyaml readme? If so I can open a follow up task to add more detail.

zanderso · 2023-04-14T20:55:38Z

@zanderso are you referring to the ciyaml readme? If so I can open a follow up task to add more detail.

Yeah, it would be great to get something like a schema for the file, what fields can go where, what their types and values can be, etc.. And of course what effects they actually have on CI.

ricardoamador · 2023-04-14T20:57:04Z

Okay cool! I will open an infra ticket for that.

Created: flutter/flutter#124893 for tracking ci.yaml updates.

jmagman · 2023-04-14T21:15:32Z

You could also remove the Macmini8,1 dimensions on this change. Example:
https://github.com/flutter/engine/blob/4ce42fed490418d13da5b5b48b8e36e583dc0ec5/.ci.yaml#L342

jmagman · 2023-04-14T21:31:47Z

You could also remove the Macmini8,1 dimensions on this change. Example:

https://github.com/flutter/engine/blob/4ce42fed490418d13da5b5b48b8e36e583dc0ec5/.ci.yaml#L342

On it: #41223

…1219)

flutter-team-archive/engine@e9739bc...f794529 2023-04-14 magder@google.com Change v2 `mac_unopt` orchestrator builder to Linux (flutter-team-archive/engine#41184) 2023-04-14 zanderso@users.noreply.github.com Specify allowed Macmini models (flutter-team-archive/engine#41219) 2023-04-14 godofredoc@google.com Migrate mac_host_engine to engine v2 builds. (flutter-team-archive/engine#41149) 2023-04-14 magder@google.com Remove cores dimension from Mac Host clang-tidy (flutter-team-archive/engine#41214) 2023-04-14 magder@google.com Run mac_host_engine orchestrator on arm Macs (flutter-team-archive/engine#41185) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…4900) flutter-team-archive/engine@e9739bc...f794529 2023-04-14 magder@google.com Change v2 `mac_unopt` orchestrator builder to Linux (flutter-team-archive/engine#41184) 2023-04-14 zanderso@users.noreply.github.com Specify allowed Macmini models (flutter-team-archive/engine#41219) 2023-04-14 godofredoc@google.com Migrate mac_host_engine to engine v2 builds. (flutter-team-archive/engine#41149) 2023-04-14 magder@google.com Remove cores dimension from Mac Host clang-tidy (flutter-team-archive/engine#41214) 2023-04-14 magder@google.com Run mac_host_engine orchestrator on arm Macs (flutter-team-archive/engine#41185) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…imension (#41223) As of #41219 all the .ci.yaml builders will run on either Macmini8,1 (x64) or Macmini9,1 (arm). Stop specifying `Macmini8,1` on individual builders and let the specified architecture be the deciding factor. Reverts #41203

Specify allowed Macmini models

348dbfb

This excludes Macmini7,1. Fixes flutter/flutter#124877

zanderso requested review from godofredoc and ricardoamador April 14, 2023 19:58

zanderso mentioned this pull request Apr 14, 2023

Do not Macmini 7,1 (Intel Iris 5100) to run engine tests flutter/flutter#124877

Closed

Fix syntax

219c9d9

godofredoc reviewed Apr 14, 2023

View reviewed changes

Update for advice

3dc5b3c

dnfield reviewed Apr 14, 2023

View reviewed changes

Update .ci.yaml

e4790a6

godofredoc approved these changes Apr 14, 2023

View reviewed changes

ricardoamador approved these changes Apr 14, 2023

View reviewed changes

zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2023

auto-submit Bot merged commit 89d9657 into main Apr 14, 2023

auto-submit Bot deleted the zanderso-patch-5 branch April 14, 2023 21:24

jmagman mentioned this pull request Apr 14, 2023

Stop specifiying Macmini8,1 in ci builders, use inherited mac_model dimension #41223

Merged

engine-flutter-autoroll mentioned this pull request Apr 14, 2023

Roll Flutter Engine from e9739bca5c66 to f7945293aced (5 revisions) flutter/flutter#124900

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2023

89d9657 Specify allowed Macmini models (flutter-team-archive/engine#4…

3d6528c

…1219)

	mac_model: "Macmini8,1\|Macmini9.1"
	mac_model: "Macmini8,1\|Macmini9,1"

Uh oh!

Conversation

zanderso commented Apr 14, 2023

Uh oh!

zanderso commented Apr 14, 2023

Uh oh!

godofredoc commented Apr 14, 2023

Uh oh!

godofredoc Apr 14, 2023

Choose a reason for hiding this comment

Uh oh!

dnfield Apr 14, 2023

Choose a reason for hiding this comment

Uh oh!

godofredoc commented Apr 14, 2023

Uh oh!

godofredoc left a comment

Choose a reason for hiding this comment

Uh oh!

zanderso commented Apr 14, 2023

Uh oh!

ricardoamador left a comment

Choose a reason for hiding this comment

Uh oh!

ricardoamador commented Apr 14, 2023

Uh oh!

zanderso commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ricardoamador commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented Apr 14, 2023

Uh oh!

jmagman commented Apr 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

zanderso commented Apr 14, 2023 •

edited

Loading

ricardoamador commented Apr 14, 2023 •

edited

Loading