This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove usage of deprecated Fuchsia event source#37641
Merged
Merged
Conversation
This capability is being removed by the Fuchsia platform (https://fuchsia-review.git.corp.google.com/c/fuchsia/+/758606), but is currently blocked on this usage. This change simply removes the capability from this tests, where it doesn't seem to be used at all.
lin-erik
approved these changes
Nov 15, 2022
lin-erik
left a comment
Contributor
There was a problem hiding this comment.
LGTM
EventSource was used by the fuchsia.git version of the text-input integration test for Chromium test cases so we should be good here
|
It looks like Mac tests are failing, can someone on flutter re-queue the run? |
Contributor
Rerunning the Mac tests |
akbiggs
approved these changes
Nov 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2022
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 16, 2022
* 6563c58 Remove felt snapshotting behavior. (flutter-team-archive/engine#37639) * c6e5564 Update language version in flutter_frontend_server/test/fixtures (flutter-team-archive/engine#37643) * eedb93e Update text editing tests (flutter-team-archive/engine#37642) * a1dd335 colorFilter as imageFilter for web (flutter-team-archive/engine#37522) * b74c2c5 Remove usage of deprecated Fuchsia event source (flutter-team-archive/engine#37641) * e56ed93 Revert "Update text editing tests (#37642)" (flutter-team-archive/engine#37653)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
…#37641) This capability is being removed by the Fuchsia platform (https://fuchsia-review.git.corp.google.com/c/fuchsia/+/758606), but is currently blocked on this usage. This change simply removes the capability from this tests, where it doesn't seem to be used at all.
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…5406) * 6563c58 Remove felt snapshotting behavior. (flutter-team-archive/engine#37639) * c6e5564 Update language version in flutter_frontend_server/test/fixtures (flutter-team-archive/engine#37643) * eedb93e Update text editing tests (flutter-team-archive/engine#37642) * a1dd335 colorFilter as imageFilter for web (flutter-team-archive/engine#37522) * b74c2c5 Remove usage of deprecated Fuchsia event source (flutter-team-archive/engine#37641) * e56ed93 Revert "Update text editing tests (flutter#37642)" (flutter-team-archive/engine#37653)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…5406) * 6563c58 Remove felt snapshotting behavior. (flutter-team-archive/engine#37639) * c6e5564 Update language version in flutter_frontend_server/test/fixtures (flutter-team-archive/engine#37643) * eedb93e Update text editing tests (flutter-team-archive/engine#37642) * a1dd335 colorFilter as imageFilter for web (flutter-team-archive/engine#37522) * b74c2c5 Remove usage of deprecated Fuchsia event source (flutter-team-archive/engine#37641) * e56ed93 Revert "Update text editing tests (flutter#37642)" (flutter-team-archive/engine#37653)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This capability is being removed by the Fuchsia platform (https://fuchsia-review.git.corp.google.com/c/fuchsia/+/758606), but is currently blocked on this usage.
This change simply removes the capability from this tests, where it doesn't seem to be used at all.
Fixes flutter/flutter#115392
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.