Pass the correct name for gclient variables in ci.yaml by godofredoc · Pull Request #37429 · flutter-team-archive/engine

godofredoc · 2022-11-08T16:05:57Z

The right name in .ci.yaml is gclient_variables instead of gclient_custom vars.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The right name in .ci.yaml is gclient_variables instead of gclient_custom vars.

drewroengoogle

LGTM!

sealesj

LGTM

…er-team-archive/engine#37429)

…archive#37429) The right name in .ci.yaml is gclient_variables instead of gclient_custom vars.

…er-team-archive/engine#37429)

* de0b58e clang-tidy: added the ability to shard jobs (flutter-team-archive/engine#37265) * 8aefb8b Roll Dart SDK from d97d5ad98893 to b22b36c0f52e (1 revision) (flutter-team-archive/engine#37400) * 2f04309 Roll Skia from aef6d301c0b5 to 0c8127b3dd7d (6 revisions) (flutter-team-archive/engine#37402) * dc7cb20 Fix boolean json property. (flutter-team-archive/engine#37403) * 512fa40 Adding release_build:true property to windows builders. (flutter-team-archive/engine#37397) * 0af8707 Add test for image readback (flutter-team-archive/engine#37401) * c6f26e0 Update display_list_image_filter_unittests to be permit Skia roll (flutter-team-archive/engine#37327) * 4e9e97b Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter-team-archive/engine#37409) * 42c2940 Pass the correct name for gclient variables in ci.yaml (flutter-team-archive/engine#37429) * 2e2a2fd Revert "Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (#37409)" (flutter-team-archive/engine#37430) * 02cb789 Roll Fuchsia Mac SDK from sa5bVGimNo3JwLV27... to d4l6A1aPw6Z0YjxmA... (flutter-team-archive/engine#37432) * c24ae18 [web] Use v8BreakIterator where possible (flutter-team-archive/engine#37317) * 306b0fe Add rects to accumulator rather than bounds (flutter-team-archive/engine#37435) * c760354 Roll Dart SDK from b22b36c0f52e to c15cdb978761 (2 revisions) (flutter-team-archive/engine#37437)

The right name in .ci.yaml is gclient_variables instead of gclient_custom vars.

…archive#37429) The right name in .ci.yaml is gclient_variables instead of gclient_custom vars.

The right name in .ci.yaml is gclient_variables instead of gclient_custom vars. Co-authored-by: godofredoc <godofredoc@google.com>

…archive#37429) The right name in .ci.yaml is gclient_variables instead of gclient_custom vars.

…15008) * de0b58e clang-tidy: added the ability to shard jobs (flutter-team-archive/engine#37265) * 8aefb8b Roll Dart SDK from d97d5ad98893 to b22b36c0f52e (1 revision) (flutter-team-archive/engine#37400) * 2f04309 Roll Skia from aef6d301c0b5 to 0c8127b3dd7d (6 revisions) (flutter-team-archive/engine#37402) * dc7cb20 Fix boolean json property. (flutter-team-archive/engine#37403) * 512fa40 Adding release_build:true property to windows builders. (flutter-team-archive/engine#37397) * 0af8707 Add test for image readback (flutter-team-archive/engine#37401) * c6f26e0 Update display_list_image_filter_unittests to be permit Skia roll (flutter-team-archive/engine#37327) * 4e9e97b Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter-team-archive/engine#37409) * 42c2940 Pass the correct name for gclient variables in ci.yaml (flutter-team-archive/engine#37429) * 2e2a2fd Revert "Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter#37409)" (flutter-team-archive/engine#37430) * 02cb789 Roll Fuchsia Mac SDK from sa5bVGimNo3JwLV27... to d4l6A1aPw6Z0YjxmA... (flutter-team-archive/engine#37432) * c24ae18 [web] Use v8BreakIterator where possible (flutter-team-archive/engine#37317) * 306b0fe Add rects to accumulator rather than bounds (flutter-team-archive/engine#37435) * c760354 Roll Dart SDK from b22b36c0f52e to c15cdb978761 (2 revisions) (flutter-team-archive/engine#37437)

Pass the correct name for gclient variables in ci.yaml

09ee5c9

The right name in .ci.yaml is gclient_variables instead of gclient_custom vars.

ricardoamador approved these changes Nov 8, 2022

View reviewed changes

drewroengoogle approved these changes Nov 8, 2022

View reviewed changes

sealesj approved these changes Nov 8, 2022

View reviewed changes

godofredoc merged commit 42c2940 into flutter-team-archive:main Nov 8, 2022

zanderso mentioned this pull request Nov 8, 2022

Skia autoroller stopped flutter/flutter#114897

Closed

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 42c2940ff6fb (9 revisions) flutter/flutter#114903

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

c824805

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 2e2a2fd97c64 (10 revisions) flutter/flutter#114904

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

b45ce27

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 02cb78905ac0 (11 revisions) flutter/flutter#114908

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

aafc334

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to c24ae1872927 (12 revisions) flutter/flutter#114909

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

6bfbb1d

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 306b0fe9ccb1 (13 revisions) flutter/flutter#114910

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

bee0303

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to c76035429c36 (14 revisions) flutter/flutter#114911

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

de2fff0

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 6daa75ad4cd5 (15 revisions) flutter/flutter#114912

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

ebb7351

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 6517ee8ee6d3 (16 revisions) flutter/flutter#114915

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

dc42a6f

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 05455ac0ade7 (23 revisions) flutter/flutter#114948

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

33ac5e5

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 9628070ee445 (24 revisions) flutter/flutter#114951

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

9a0cf83

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to fc7293441ff5 (25 revisions) flutter/flutter#114953

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

377b75d

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to fc7293441ff5 (25 revisions) flutter/flutter#114955

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

f75e0a6

…er-team-archive/engine#37429)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

451aba6

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to f8048be39a7c (30 revisions) flutter/flutter#114969

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

5121473

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 214b84137bbe (31 revisions) flutter/flutter#114972

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

2c99b60

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 214b84137bbe (31 revisions) flutter/flutter#114976

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

43e7e3d

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 8ecb1c913ba5 (32 revisions) flutter/flutter#114977

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

bfaacda

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 2e2a2fd97c64 (10 revisions) flutter/flutter#114996

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

07f07de

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 1a8888b5170b (33 revisions) flutter/flutter#114997

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

3cad985

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to ca303bfd4eed (34 revisions) flutter/flutter#115001

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

2151827

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 5d0df764b03a (35 revisions) flutter/flutter#115003

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

24927ad

…er-team-archive/engine#37429)

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to c76035429c36 (14 revisions) flutter/flutter#115008

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

a3f046d

…er-team-archive/engine#37429)

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Nov 9, 2022

Pass the correct name for gclient variables in ci.yaml (flutter-team-…

7aa7ea6

…archive#37429) The right name in .ci.yaml is gclient_variables instead of gclient_custom vars.

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 5f88ee42b1c3 (37 revisions) flutter/flutter#115011

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

42c2940 Pass the correct name for gclient variables in ci.yaml (flutt…

d9431af

…er-team-archive/engine#37429)

itsjustkevin pushed a commit that referenced this pull request Nov 14, 2022

Pass the correct name for gclient variables in ci.yaml (#37429)

c8c642e

The right name in .ci.yaml is gclient_variables instead of gclient_custom vars.

muditatandon pushed a commit to muditatandon/engine that referenced this pull request Nov 15, 2022

Pass the correct name for gclient variables in ci.yaml (flutter-team-…

e17f228

…archive#37429) The right name in .ci.yaml is gclient_variables instead of gclient_custom vars.

muditatandon added a commit that referenced this pull request Nov 15, 2022

Pass the correct name for gclient variables in ci.yaml (#37429) (#37646)

18867d4

The right name in .ci.yaml is gclient_variables instead of gclient_custom vars. Co-authored-by: godofredoc <godofredoc@google.com>

schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022

Pass the correct name for gclient variables in ci.yaml (flutter-team-…

8f2e756

…archive#37429) The right name in .ci.yaml is gclient_variables instead of gclient_custom vars.

godofredoc deleted the fix_gclient_vars branch April 6, 2023 20:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Pass the correct name for gclient variables in ci.yaml#37429

Pass the correct name for gclient variables in ci.yaml#37429
godofredoc merged 1 commit into
flutter-team-archive:mainfrom
godofredoc:fix_gclient_vars

godofredoc commented Nov 8, 2022

Uh oh!

drewroengoogle left a comment

Uh oh!

sealesj left a comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

godofredoc commented Nov 8, 2022

Pre-launch Checklist

Uh oh!

drewroengoogle left a comment

Choose a reason for hiding this comment

Uh oh!

sealesj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants