Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Support native functions in test fixtures#35357

Merged
cbracken merged 1 commit into
flutter-team-archive:mainfrom
cbracken:win-native-functions
Aug 12, 2022
Merged

[Windows] Support native functions in test fixtures#35357
cbracken merged 1 commit into
flutter-team-archive:mainfrom
cbracken:win-native-functions

Conversation

@cbracken

Copy link
Copy Markdown
Contributor

Adds the ability to register native functions for use in test fixtures.
This allows registering native C++ functions that can be invoked from
Dart code to perform the following common actions:

  • Signal a waiting latch in the C++ part of the test.
  • Pass data back to the C++ part of the test.
  • Allow the C++ part of the test to pass data to the test.

Fixes: flutter/flutter#109242
Fixes: flutter/flutter#87299

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Comment thread shell/platform/windows/flutter_windows_engine.h Outdated

@loic-sharma loic-sharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread shell/platform/windows/flutter_windows_unittests.cc Outdated
Comment thread shell/platform/windows/flutter_windows_unittests.cc Outdated
Adds the ability to register native functions for use in test fixtures.
This allows registering native C++ functions that can be invoked from
Dart code to perform the following common actions:

* Signal a waiting latch in the C++ part of the test.
* Pass data back to the C++ part of the test.
* Allow the C++ part of the test to pass data to the test.

Fixes: flutter/flutter#109242
Fixes: flutter/flutter#87299
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

[Windows] Support registering native functions in WindowsTestContext Add Windows test helper API and placeholder test

3 participants