This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] remove references to IE11 and old Edge; treat Samsung browser as Blink#35205
Merged
auto-submit[bot] merged 4 commits intoAug 31, 2022
Merged
Conversation
|
Gold has detected about 1 new digest(s) on patchset 1. |
ditman
approved these changes
Aug 6, 2022
ditman
left a comment
Contributor
There was a problem hiding this comment.
Good riddance!
(I'm surprised that there wasn't more browser-specific code related to those browsers, wow!)
| // Assume unknown otherwise, but issue a warning. | ||
|
|
||
| // Assume Blink otherwise, but issue a warning. | ||
| print('WARNING: failed to detect current browser engine.'); |
Contributor
There was a problem hiding this comment.
Suggested change
| print('WARNING: failed to detect current browser engine.'); | |
| print('WARNING: failed to detect current browser engine. Assuming it is `blink`.'); |
Contributor
Author
There was a problem hiding this comment.
Done, but since this is developer-visible message instead of "blink" I say "Chromium-compatible browser".
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
f92893e to
5c2feab
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 31, 2022
* d782c33 [web] roll CanvasKit to 0.36.1 (flutter-team-archive/engine#35747) * 300592b allows mallocmapping copies of size zero (flutter-team-archive/engine#35803) * 61e4c07 Generate mac os framework with a global generator. (flutter-team-archive/engine#35673) * 7a03a54 Roll Skia from 545e45ab4d5d to 27a2eeacd330 (11 revisions) (flutter-team-archive/engine#35805) * 89909d9 Fix DartPerformanceMode enum mismatch (flutter-team-archive/engine#35806) * ead1348 Queue all semantic nodes & actions before completing batch (flutter-team-archive/engine#35792) * adec6ed Run clang-tidy and Mac Unopt on Xcode beta (flutter-team-archive/engine#35793) * eb6e2e0 Roll Skia from 27a2eeacd330 to 18b36bd2e2a3 (1 revision) (flutter-team-archive/engine#35807) * e74352c Remove extract_far.dart (flutter-team-archive/engine#35801) * 5ee7b38 Test cover 'toImage'. (flutter-team-archive/engine#35791) * 8ed1e6c Roll Skia from 18b36bd2e2a3 to 7c67a21eec59 (3 revisions) (flutter-team-archive/engine#35810) * cc2a323 Roll Dart SDK from 9faec45da06c to 7e5a69f6b25f (1 revision) (flutter-team-archive/engine#35811) * c2a2a56 Roll Fuchsia Linux SDK from NwG1XTWHxB9R3XcU5... to usGLIrlCJW1C1yaF1... (flutter-team-archive/engine#35812) * 8ab3b8f Migrate testing/symbols to null safety (flutter-team-archive/engine#35809) * 7e27b92 Roll Skia from 7c67a21eec59 to 3abad1ab16cc (1 revision) (flutter-team-archive/engine#35816) * 4cb5be0 [web] remove references to IE11 and old Edge; treat Samsung browser as Blink (flutter-team-archive/engine#35205) * 5154b8a Roll Fuchsia Mac SDK from 4GZkuoQmvVanO84uA... to V_dBCcwGfOqJkrG9b... (flutter-team-archive/engine#35817) * b5a5a0d Roll Dart SDK from 7e5a69f6b25f to 5a2737b71877 (1 revision) (flutter-team-archive/engine#35818) * e114573 [dart:ui] Adds a reusable FragmentShader (flutter-team-archive/engine#35253) * 26d6bcf Roll Skia from 3abad1ab16cc to a7829f6da292 (1 revision) (flutter-team-archive/engine#35819) * 6c9f6f5 Roll Skia from a7829f6da292 to 83b5d7ae4bca (2 revisions) (flutter-team-archive/engine#35821) * 169181f Make shader mask layer code builder aware (flutter-team-archive/engine#35622) * 06925ed Roll Fuchsia Linux SDK from usGLIrlCJW1C1yaF1... to 5YEIlndU4ncjOl9I_... (flutter-team-archive/engine#35824) * 7a40a0a Roll Skia from 83b5d7ae4bca to e4a2061eb1fc (1 revision) (flutter-team-archive/engine#35826) * 43ee40e Engine startup event timed after VM initializes (flutter-team-archive/engine#35713) * 9eb524b Roll Fuchsia Mac SDK from V_dBCcwGfOqJkrG9b... to sgXD5SyRPOxGjWV4q... (flutter-team-archive/engine#35829) * cfdc83a Roll Skia from e4a2061eb1fc to 34df0f94c849 (1 revision) (flutter-team-archive/engine#35828) * 90d65fa fix null access for CkParagraph.dispose (flutter-team-archive/engine#35815) * ef039c1 Update the API check script for the latest Dart analyzer APIs (flutter-team-archive/engine#35831) * c3c8727 Revert "[web] roll CanvasKit to 0.36.1 (#35747)" (flutter-team-archive/engine#35837) * db97b55 Roll Skia from 34df0f94c849 to e0b87738eca7 (5 revisions) (flutter-team-archive/engine#35832) * f69e0cc add enterkeyhint property to web textfields (flutter-team-archive/engine#35411) * 54a1b59 Add a comment in the scenario app to meet the latest analyzer requirements (flutter-team-archive/engine#35838) * d993e0d Revert "[dart:ui] Adds a reusable FragmentShader (#35253)" (flutter-team-archive/engine#35843)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove references to IE11 and old Edge (this change is not breaking as Flutter Web never really worked on these); treat Samsung browser as Blink.
Fixes flutter/flutter#108999.
Potentially also fixes the issue flutter/flutter#107786, but if our regex was busted then perhaps we never detected Samsung browser and so never tried applying the non-mobile version of the text field.