Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland: Roll clang and buildroot#33339

Merged
zanderso merged 1 commit into
flutter-team-archive:mainfrom
zanderso:clang-roll
May 14, 2022
Merged

Reland: Roll clang and buildroot#33339
zanderso merged 1 commit into
flutter-team-archive:mainfrom
zanderso:clang-roll

Conversation

@zanderso

@zanderso zanderso commented May 14, 2022

Copy link
Copy Markdown
Contributor

This is a reland of #33325. It fixes flutter_tester in profile and release modes by including the new linker argument in those builds, which I had mistakenly excluded in the last PR due to link errors that were actually caused by an incomplete listing of dependencies on some unit tests.

@zanderso zanderso requested a review from dnfield May 14, 2022 05:50
@zanderso zanderso merged commit b2f31f5 into flutter-team-archive:main May 14, 2022
@zanderso zanderso deleted the clang-roll branch May 14, 2022 13:04
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2022
@engine-flutter-autoroll
b2f31f5 Reland: Roll clang and buildroot (flutter-team-archive/engine…
70c1703 
…#33339)
zanderso pushed a commit to flutter/flutter that referenced this pull request May 14, 2022
@engine-flutter-autoroll
b2f31f5 Reland: Roll clang and buildroot (flutter-team-archive/engine…
e915479 
…#33339) (#103809)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request May 14, 2022
flutter: b2f31f56f Reland: Roll clang and buildroot (flutter-team-arc…
f1adc18 
…hive/engine#33339) (#103809)

Commit: e91547911b30a58e9883be754dd0032f181ca600
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
14c2e96 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
87912bb 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
7a7c79f 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
c5dc7bf 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
54cbb81 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
3e8c5bc 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
f34c8ef 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
e84ce31 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
6cd28e4 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
1d6cc97 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
4edcfe1 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
3bd478d 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
9e63231 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
4701763 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
ebd05cd 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
6bc2196 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
607b89a 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
fb820fd 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
aadd531 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
518ff25 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
abc3105 
…ive/engine#33339) (flutter/flutter#103809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
86638a5 
…ive/engine#33339) (flutter/flutter#103809)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@zanderso @houhuayong
Reland: Roll clang and buildroot (flutter-team-archive#33339)
72a2957
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
56880db 
…ive/engine#33339) (flutter/flutter#103809)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
e915479 b2f31f56f Reland: Roll clang and buildroot (flutter-team-arch…
1f9ef78 
…ive/engine#33339) (flutter/flutter#103809)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@dnfield dnfield dnfield approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

embedder Related to the embedder API platform-ios platform-macos

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @dnfield