Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[macOS, Keyboard] Convert abrupt repeat events to down events#31941

Merged
dkwingsmt merged 2 commits into
mainfrom
mac-key-abrupt-repeat-event-to-down
Mar 10, 2022
Merged

[macOS, Keyboard] Convert abrupt repeat events to down events#31941
dkwingsmt merged 2 commits into
mainfrom
mac-key-abrupt-repeat-event-to-down

Conversation

@dkwingsmt

@dkwingsmt dkwingsmt commented Mar 10, 2022

Copy link
Copy Markdown
Contributor

With this PR, if a down event with isARepeat is observed without preceding down events for this key, this repeat event will be converted to a key down instead of key repeat, ensuring event regularity.

This irregular message sequence will be observed when the message list is filtered, such as what @cbracken and @LongCatIsLooong are working on with IME.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants