Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add include to header for coming libc++ updates#31835

Merged
fluttergithubbot merged 1 commit into
mainfrom
zanderso-patch-2
Mar 4, 2022
Merged

Add include to header for coming libc++ updates#31835
fluttergithubbot merged 1 commit into
mainfrom
zanderso-patch-2

Conversation

@zanderso

@zanderso zanderso commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

See cl/432474947

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Development

Successfully merging this pull request may close these issues.

3 participants