This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Use the systrace recorder if systracing is enabled at startup, and enable systracing in release mode on Android"#29071
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
Author
|
Landing revert TBR to green the tree. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2021
… startup, and enable systracing in release mode on Android (flutter#28903)" (flutter-team-archive/engine#29071)
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
Oct 8, 2021
…, and enable systracing in release mode on Android (flutter-team-archive#28903)" (flutter-team-archive#29071)" This reverts commit a2773d5.
Contributor
|
LGTM |
dnfield
added a commit
that referenced
this pull request
Oct 8, 2021
* Reland "Use the systrace recorder if systracing is enabled at startup, and enable systracing in release mode on Android (#28903)" (#29071)" This reverts commit a2773d5. * More logcat * more logs * Remove wait * Avoid plugin registrar exception * DEFAULT instead of LAUNCHER * use am instead of monkey * Update android_systrace_test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #28903
flutter/flutter#91463