This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Don't use rFD in pre-Q versions#28593
Merged
Merged
Conversation
dnfield
reviewed
Sep 13, 2021
dnfield
reviewed
Sep 13, 2021
| // permissions in some Android versions. | ||
| // * rFD behavior isn't tested on pre-Q versions. | ||
| // See https://github.com/flutter/flutter/issues/46172, and | ||
| // https://github.com/flutter/flutter/issues/88767. |
Contributor
There was a problem hiding this comment.
nit: consider adding that there are vendor-specific bugs.
How confident are we that this API works on all vendors after Q?
Author
There was a problem hiding this comment.
I only know that a CTS test was added. Vendors should be running these tests, but we don't really know.
dnfield
approved these changes
Sep 13, 2021
dnfield
left a comment
Contributor
There was a problem hiding this comment.
LGTM with nit.
I am wondering if we know for sure that the Android team's coverage of reportFullyDrawn is good enough to trust it on all vendors after Q.
Author
Android uses CTS for this. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 15, 2021
christopherfujino
added a commit
that referenced
this pull request
Sep 16, 2021
* 'Update Dart SDK to 3300f32' * Don't use rFD in pre-Q versions (#28593) * updated 3rd party license golden * hard-code Build.VERSION_CODE.S * renew cirrus key (#28584) Co-authored-by: Emmanuel Garcia <egarciad@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#88767
We cannot safely rely on this API since there's no test in Android prior to Q.