This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[canvaskit] remove the DOM node of unrendered platform view#24001
Merged
yjbanov merged 1 commit intoJan 29, 2021
Conversation
ditman
approved these changes
Jan 27, 2021
ditman
left a comment
Contributor
There was a problem hiding this comment.
This change makes sense to me! Thanks for the fix!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2021
christopherfujino
added a commit
that referenced
this pull request
Feb 3, 2021
…24142) * add ffi_allocation_patch.dart to libraries.yaml 2 (#23954) * Use `runes` to get code units in CanvasKit. (#24024) * [windows] Honor only valid resize requests (#23990) * Load FlutterLoader when creating FlutterEngineGroup (#23980) * [canvaskit] remove the DOM node of unrendered platform view (#24001) * update dart to 2.12.0-259.8.beta * [web] Fix svg based stroke rendering. (#23969) * [canvaskit] fix text background, foreground, color; add text style tests (#23800) * [canvaskit] fix text background, foreground, familyFallback; add style tests * add leak test * update goldens_lock.yaml * remove solo * Warn when popping out of empty text style stack * [web] Fix alignment issue in rich paragraphs (#23965) * [web] Implement CanvasParagraph.getLineBoundary (#24037) * [web] Fix text alignment when transform + tight constraints + DOM rendering (#24036) * update licenses_third_party golden Co-authored-by: Daco Harkes <dacoharkes@google.com> Co-authored-by: Harry Terkelsen <hterkelsen@users.noreply.github.com> Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com> Co-authored-by: xster <xster@google.com> Co-authored-by: Yegor <yjbanov@google.com> Co-authored-by: Ferhat <ferhat@gmail.com> Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the DOM node of unrendered platform view. Until we have
<slot>s the platform view nodes need to be physically removed from thedocument. Otherwise, they leave halos until disposed of.Fixes flutter/flutter#74676
Fixes flutter/flutter#69813