Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add SDK licenses to DEPS#22551

Merged
blasten merged 1 commit into
flutter-team-archive:masterfrom
blasten:android_licenses
Nov 17, 2020
Merged

Add SDK licenses to DEPS#22551
blasten merged 1 commit into
flutter-team-archive:masterfrom
blasten:android_licenses

Conversation

@blasten

@blasten blasten commented Nov 16, 2020 •
edited
Loading

Copy link
Copy Markdown

Provides Android SDK licenses, so the step can be removed from the recipes.

Related Issues

flutter/flutter#70633

@blasten blasten requested a review from godofredoc November 16, 2020 22:02
@google-cla google-cla Bot added the cla: yes label Nov 16, 2020
godofredoc
godofredoc reviewed Nov 16, 2020
View reviewed changes
Comment thread DEPS Outdated
'packages': [
{
'package': 'flutter/android/sdk/licenses',
'version': 'last_updated:2020-11-16T13:56:24-0800'

@godofredoc godofredoc Nov 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we tag it with a ref or tag instead of using the date? E.g something more relevant to the state of the package?

@godofredoc godofredoc Nov 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we believe we need only one package in prod at a time then we add a ref release to the cipd package and use it here.

godofredoc
godofredoc approved these changes Nov 16, 2020
View reviewed changes

@godofredoc godofredoc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if other parts on the engine use last_updated tag then LGTM

@blasten blasten merged commit 8d93ea0 into flutter-team-archive:master Nov 17, 2020
@blasten blasten deleted the android_licenses branch November 17, 2020 02:01
@dcharkes

dcharkes commented Nov 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

The breaks the Flutter HHH build on the Dart CI and the Flutter build on the Dart CQ.

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8863407173609080016/+/steps/bot_update/0/stdout

failed to resolve flutter_internal/android/sdk/licenses@latest (line 28): prefix "flutter_internal/android/sdk/licenses" doesn't exist or "user:dart-luci-try-builder@dart-ci.iam.gserviceaccount.com" is not allowed to see it, run cipd auth-login to login or relogin
Error: Command 'cipd ensure -log-level error -root /b/s/w/ir/cache/builder -ensure-file /b/s/w/ir/tmp/t/tmpLrOKx5.ensure' returned non-zero exit status 1

gclient sync fails because of an authentication problem.

I presume this is not only a problem to the Dart CI and CQ, but everyone trying to do gclient sync.

@rmistry

rmistry commented Nov 17, 2020

Copy link
Copy Markdown
Contributor

This also seems to be causing all rollers into flutter/engine to fail: https://bugs.chromium.org/p/skia/issues/detail?id=10961

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2020
@engine-flutter-autoroll
8d93ea0 Add SDK licenses to DEPS (flutter-team-archive/engine#22551)
aa1e2d1
pcsosinski pushed a commit to pcsosinski/engine that referenced this pull request Nov 17, 2020
Add SDK licenses to DEPS (flutter-team-archive#22551)
ec351f7
pcsosinski pushed a commit that referenced this pull request Nov 17, 2020
[flutter_releases] Flutter 1.24.0-10.2.pre engine cherrypicks (#22568)
07c1eed 
* Update 1.24 engine to use Dart 2.12.0-29.10.beta

* Add SDK licenses to DEPS (#22551)

* Use flutter public package for the time being (#22560)

Co-authored-by: Emmanuel Garcia <egarciad@google.com>
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
@chaselatta
Add SDK licenses to DEPS (flutter-team-archive#22551)
30b9fe4
christopherfujino added a commit that referenced this pull request Dec 8, 2020
@christopherfujino
Add SDK licenses to DEPS (#22551) (#22938)
86a708f 
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
@acoutts acoutts mentioned this pull request Dec 11, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@godofredoc godofredoc godofredoc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blasten @dcharkes @rmistry @godofredoc