This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add integer input tests for lerpDouble#20880
Merged
Merged
Conversation
The `a` and `b` parameters to `lerpDouble` have type `num`. This adds tests for integer parameter values.
Contributor
|
no null & NaN tests? :-P |
Hixie
approved these changes
Aug 29, 2020
Contributor
Author
|
Haha, added the null/NaN tests in #20871 so they'd get a few minutes of fame before they got replaced. By the time I'm done, here's hoping this thing's going to have at least 5% branch coverage, given all the possible inputs. Now that the tests are there though, it's at least fractionally easier to add em in the future. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
aandbparameters tolerpDoublehave typenum. This addstests for integer parameter values.